search

tomasbjerre / simple-bitbucket-commit-checker

Simple, and easy to use, commit checker for Atlassian Bitbucket Server
https://marketplace.atlassian.com/plugins/se.bjurr.sscc.sscc
Other
21 stars 19 forks source link

Newline character in output #67

Closed lexxssol closed 7 years ago

lexxssol commented 7 years ago

simple-bitbucket-commit-checker/src/main/java/se/bjurr/sbcc/SbccPrinter.java:22

contains the following line:

public static String NL = System.getProperty("line.separator");

which gives CR+LF line separator on windows systems.

However, this carriage return symbol introduces problems like this one:

https://gitlab.com/tortoisegit/tortoisegit/issues/2921

I believe the proper way is to use system-independent line delimiter (always LF) or make this configurable.

What are your thoughts?

Thank you.

Best regards, Alex.

tomasbjerre commented 7 years ago

I released this in 2.11. Open issue again if any problems!

lexxssol commented 7 years ago

Thanks for your help!