search

tomasbjerre / simple-bitbucket-commit-checker

Simple, and easy to use, commit checker for Atlassian Bitbucket Server
https://marketplace.atlassian.com/plugins/se.bjurr.sscc.sscc
Other
21 stars 19 forks source link

SBCC not parsing commit messages #78

Closed pemercer closed 7 years ago

pemercer commented 7 years ago

We wanted to use the SBCC to look for keywords in the commit message and block. Does not seem to matter what we check off for rules, it still will allow anything to be merged.

Bitbucket DC 5.3.2 SBCC version 3.9

tomasbjerre commented 7 years ago

Give an example that does not work.

pemercer commented 7 years ago

screen shot 2017-10-30 at 10 36 09 am screen shot 2017-10-30 at 10 37 00 am screen shot 2017-10-30 at 10 37 11 am

3 screen shots attached, commit message in my PR is test, nowhere close to meeting requirements. Even if I check box that it must match BOTH rules it still goes thru fine.

tomasbjerre commented 7 years ago

You are specifying the branch wrong. Here is what you have: https://jex.im/regulex/#!flags=&re=release%2F*

You probably want refs/heads/release/.*. The . before the * and also start with refs/heads/: https://jex.im/regulex/#!flags=&re=refs%2Fheads%2Frelease%2F.*

pemercer commented 7 years ago

Thanks will test out the branch syntax

pemercer commented 7 years ago

Figured it out, since this is a pre-commit hook it should be enabled for all branches. It has an option in there for pull requests how do you even get to pull requests if it is blocked on commit.

tomasbjerre commented 7 years ago

Is it solved? Can it be closed?

pemercer commented 7 years ago

So it does block commits based on commit message, what I am curious about is it has a section dealing with pull-requests and parsing the commit message there. We are looking to block commits on certain branches if the commit message in the pull request does not contain a specific text. Will the plugin enable that?

Thanks, Pete Mercer

From: Tomas Bjerre notifications@github.com Reply-To: tomasbjerre/simple-bitbucket-commit-checker reply@reply.github.com Date: Monday, October 30, 2017 at 3:19 PM To: tomasbjerre/simple-bitbucket-commit-checker simple-bitbucket-commit-checker@noreply.github.com Cc: "pemercer@cisco.com" pemercer@cisco.com, State change state_change@noreply.github.com Subject: Re: [tomasbjerre/simple-bitbucket-commit-checker] SBCC not parsing commit messages (#78)

Is it solved? Can it be closed?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/tomasbjerre/simple-bitbucket-commit-checker/issues/78#issuecomment-340555171, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Ac2atxSQ5sMfpf2Mw1NFCR4ukTx9bN9gks5sxiFZgaJpZM4QLRrD.

tomasbjerre commented 7 years ago

Yes that should work.