tomasbjerre / simple-bitbucket-commit-checker

Simple, and easy to use, commit checker for Atlassian Bitbucket Server
https://marketplace.atlassian.com/plugins/se.bjurr.sscc.sscc
Other
21 stars 19 forks source link

Check Pull Requests disables checking commits when pushed #86

Open Sardtok opened 6 years ago

Sardtok commented 6 years ago

We have regex validation of commit messages. The commit messages aren't checked on push if we enable the check pull requests option. Along with other hooks (force push disabling, verify committer, etc.), an interactive rebase to fix the issue is not possible without disabling a bunch of hooks temporarily.

If I disable the PR check, commit messages are checked on push as expected. This would stop the above problem where someone pushes something to origin that shouldn't be allowed, then creates a PR.

It seems PRs are checked anyway, though, as I cannot merge the PR even with the PR check option disabled, however, the commit message validation response shows up when trying to merge, and doesn't disable the button.