tomasmcm / SpotiWeb

Electron wrapper of play.spotify.com
Creative Commons Attribution Share Alike 4.0 International
98 stars 13 forks source link

SpotiWeb 32-bit release is packaged with 64-bit Flash plugin PepperFlashPlayer-linux.so #18

Open Knysliux001 opened 7 years ago

Knysliux001 commented 7 years ago

After logging in with Facebook login, SpotiWeb interface would start appearing but stops showing error message for a very brief moment: "Please enable Flash to use Spotify web player. Click here to enable Flash"

spotiweb flash disabled error

Click here to enable Flash part seems to be a link, but since page automatically reloads in a split of a second every time it's impossible to press and check what it would open.

My system is LinuxMint Mate Serena 18.1 32-bit with adobe-flashplugin package installed (Version: 1:20161213.1-0ubuntu0.16.04.1) and it does work in Firefox version 50.1.0 reporting Adobe Flash 24.0.0.186 version. Linux kernel: Linux version 4.4.0-57-generic (buildd@lcy01-15) (gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.4) ) #78-Ubuntu SMP Fri Dec 9 23:46:51 UTC 2016

What type of additional information could I provide to resolve this issue?

tomasmcm commented 7 years ago

@Knysliux001 Hey, sorry to hear that

Can you try to open https://play.spotify.com on Chrome and check if you can play any music (SpotiWeb does not use the system flash, it works like Chrome and has its own pepper-flash plugin).

Knysliux001 commented 7 years ago

At first Chromium showed the same error message about flash disabled: chromium error However since it did not close the page I was able to press on Click here to enable Flash. chromium run flash After allowing 'Run Flash' Spotify now works fine in Chromium even after closing and reopening the browser it never asks permission again. Chromium is using this system's Flash plugin: "Using PPAPI flash. --ppapi-flash-path=/usr/lib/adobe-flashplugin/libpepflashplayer.so" since you write that SpotiWeb does not use the system flash it is nearly irrelevant.

Nothing changed in SpotiWeb, it loads a page until "Please enable Flash to use Spotify web player. Click here to enable Flash" and keeps reloading itself.

Knysliux001 commented 7 years ago

Found what is causing the problem. 32-bit release https://github.com/tomasmcm/SpotiWeb/releases/download/v0.5.0/SpotiWeb-linux-ia32.tar.gz is packaged with a 64-bit Flash library!

$ file SpotiWeb-linux-ia32/resources/app.asar.unpacked/plugins/PepperFlashPlayer-linux.so
SpotiWeb-linux-ia32/resources/app.asar.unpacked/plugins/PepperFlashPlayer-linux.so: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, BuildID[sha1]=da1ee00864289c479a98ba325d50fad2089386a0, stripped
Knysliux001 commented 7 years ago

As a workaround this fixes Flash library issue also confirming above statement: ln -fs /usr/lib/adobe-flashplugin/libpepflashplayer.so /path/to/spotiweb/unpacked/SpotiWeb-linux-ia32/resources/app.asar.unpacked/plugins/PepperFlashPlayer-linux.so After linking to a 32-bit library all works as it did on my 64-bit machine.

Knysliux001 commented 7 years ago

I believe only @tomasmcm would be able to fix this packaging mismatch issue in a next release of SpotiWeb :)