tomasmcm / SpotiWeb

Electron wrapper of play.spotify.com
Creative Commons Attribution Share Alike 4.0 International
98 stars 13 forks source link

Spotify New Web Player #20

Open tomasmcm opened 7 years ago

tomasmcm commented 7 years ago

Well... we all knew this day would come... Spotify has updated its WebPlayer and SpotiWeb stopped working...

Good news is that the new version does not seem to use flash, so no more messing around with pepper-flash plugin.

Bad news is that there seems to be an error when trying to play songs: Uncaught (in promise) NO_TRACK_PLAYER in web-player.62f99c3b.js:27

I've tried opening "https://play.spotify.com" in Min and in Brave (two electron browsers) and they have the same error. It almost looks like Spotify is targeting electron wrappers...

Even in Chrome and Firefox there are a lot of errors in the console, although music actually plays..., but this makes me think this is not the "final" version of the web player.

Thank you all for your patience and for using SpotiWeb in the first place! There have been more than 3600 downloads at the moment!

If anyone finds more information about these issues do not hesitate to post it here, as it would be very much appreciated.

xblackbytesx commented 7 years ago

Sadly I'm also experiencing this issue on pretty much all the browsers you already mentioned. I'm suspecting DRM as somehow being involved with this issue. Haven't really investigated extensively though but that's the first thing that came to mind. Will further investigate soon!

renatodeleao commented 7 years ago

@tomasmcm just FYI, you're actually redirected to https://open.spotify.com when trying to access the web player (chrome & firefox). In Safari you can still access https://play.spotify.com without redirection.

renatodeleao commented 7 years ago

Another small thing that might be related.. Now you can use spotify connect to control spotify from other devices... if you're running spotiweb and have your spotify open on the web or mobile you can actually use it... which, of course, totally defeats the purpose :P

image

jpvispo commented 7 years ago

Here in South America is still working, perhaps a geolocalization restriction to the newer version. I tried Chrome too and still working with flash.

davejm commented 7 years ago

I also have not experienced issues. As @jpvispo said, it might be a localised test but it probably will break for everyone once the new version's finalised.

tomasmcm commented 7 years ago

Thank you guys. That's good news. I've noticed a lot of bugs with the new version of Spotify (open.spotify.com) so let's hope to get SpotiWeb working before the new version is pushed worldwide.

fmoreyra commented 7 years ago

as jpvispo said, here in Argentina SpotiWeb is working correctly

alagos commented 7 years ago

In Chile is still working :+1:

tomasmcm commented 7 years ago

Nice to see that the rollout has been gradual. I've experience multiple rollbacks between the old and new Web Player versions...

Nevertheless it seems it's about to go live for everyone and I'm very happy to say I found the source of the bug!

Apparently Spotify ditched the Flash plugin and started using React, but they now require the Widevine DRM plugin (some users on Firefox said they needed to activate DRM support which led me to search "electron DRM" and the first result is about Widevine 🙌 ).

I've created a new branch with the changes required for this new Web Player (quite a lot of classes changed name and notifications stopped working...). I'll probably have to keep both versions for now, I'm thinking about how to detect if a user has the old or new version (I noticed the new version is open.spotify.com so that could be a good way to check).

I'm hoping to get the new version ready next week! Thank you all for not giving up on SpotiWeb just yet!

davejm commented 7 years ago

@tomasmcm hope the new branch is coming along well :) In the meantime I created PR #21 that seems to temporarily fix the current version (stops the redirect)

alagos commented 6 years ago

Since today (with spotiweb 0.5.1) it started to appear the message: This browser is not compatible with Spotify web player captura de pantalla_2017-09-07_10-25-26

I'm not sure if it has to do with this issue and is part of the gradual rollout you mentioned.