tomasmcm / SpotiWeb

Electron wrapper of play.spotify.com
Creative Commons Attribution Share Alike 4.0 International
98 stars 13 forks source link

A few bugs in the new version #26

Open faltamiranda opened 7 years ago

faltamiranda commented 7 years ago

Still has ads Ads apears and can't be skipped.

Hotkeys The hotkey functionality for skip and pause doesn't work anymore.

Lyrics When clicking in the lyrics icon, nothing happens (it doesn't show the lyrics).

Compile new relese When compiling the new version, it threw the same browser error that appeared in the last version

tomasmcm commented 7 years ago

Hi @faltamiranda can you run the development version and post the errors you get?

For the ads please do the following:

If you could do that it would be very very helpful, Thanks!

jaivalis commented 7 years ago

Hi @tomasmcm, as @faltamiranda mentioned, compiling the source locally produces the same browser error that appeared before the latest release: "This browser doesn't support Spotify Web Player. Switch browsers or download Spotify for your desktop."

tomasmcm commented 7 years ago

@faltamiranda @jaivalis sorry guys... I forgot to mention you need to be in the https://github.com/tomasmcm/SpotiWeb/tree/openSpotify branch (note to future self: merge this...)

faltamiranda commented 7 years ago

@tomasmcm Urls

https://spclient.wg.spotify.com/ads/v1/ads/leaderboard?payload=e30=

https://shrt.spotify.com/t/t/1/c26f125b08db4dccaaab3b8551e0973f

https://securepubads.g.doubleclick.net/gpt/pubads_impl_147.js

https://adeventtracker.spotify.com/t?adId=193987092&u_play=http://pubads.g.doubleclick.net/pcs/view?xai%3DAKAOjsuXG1bpIZw3_KpUcsC2YaIxyt9OV9KFMxfV9UYNLtn00HtUfu42dslZUMHEm0UTb6yycU1GdROW9w_XV4QmMM6BfWQRM5bckifx37OpK0nUtk_WFOa13dTgLKGL3e6ul1sXOcmWs5RKJdlIOulAkIrwjvHoIEF8qBY-rAasewqFvN_Q5e83d_llCc_Tl0Biux7i1PTFfbU_n2MvfiK-UqylNj2nbEzh7Sjr_EOMxfOkEg%26sai%3DAMfl-YTBZac_sGFKkrjtDPBja6SRXVrUmEaFlbXUOss8kBRQfBltTnt03Zc%26sig%3DCg0ArKJSzABZ_utIlPH5EAE%26adurl%3D&u_start=http://pubads.g.doubleclick.net/pagead/conversion/?ai%3DB8tcmu-a3Wa-BGcvapgPdgqPICty22YQJAAAAEAEgvK75HjgAWKymoKeqAmCh8IaAWLIBD3d3dy5zcG90aWZ5LmNvbboBBzF4MV94bWzIAQXaARdodHRwOi8vd3d3LnNwb3RpZnkuY29tL6kC0bb2ozYRtD7AAgLgAgDqAgwvNjQ2NTA1Mi93ZWL4AoHSHpADnASYA9AFqAMB0ASQTuAEAdIFBRCUhMBckAYBoAYj2AcB4AcP0ggHCIBhEAEYAw%26sigh%3D2Feb2R5Buy8%26label%3Dpart2viewed%26ad_mt%3D&systemInfo=web_player&partnerName=spotify&request_id=5010e98e-37aa-46b3-8b16-b12c20fc6d95&platform=unknown&adresponse_id=efe4caf5-02bf-4911-8644-7017b77618b0&m=0A6uckpFpbBvMQEORkp4aibKF-8bFTM_ZWId2Jf0Ig4=

https://adeventtracker.spotify.com/monitoring?event=creativeView&slot=stream&product=PRODUCT_JSSDK&brand=spotify&model=web_player

tomasmcm commented 7 years ago

@faltamiranda Thanks for the urls.

I've since come across some ads too... it seems they only appear if you listen to a few songs without skipping.

The reason why they are still appearing is because Spotify changed their system, and now the ads come from the same URL as regular songs, and therefore there is no way to just block them. The urls you posted are from the banners and popup stuff that would appear in the "normal" version, but it is good to check that you are getting similar blocked urls as I am, as I'm using those to check for an upcoming ad.

I'm testing a couple of ways to fix this, and will hopefully post a new release soon.