Closed Adobe-Android closed 8 years ago
Thanks for giving a try on my plugin and having time to make pull request ;) Pull Request #2 @Adobe-Android
No problem. I was looking for some cool C++ plugins and really liked yours. I ran into an unfortunate compatibility with another one I was trying to use. I really appreciate you accepting it. I'm actually not familiar with CoffeeScript, but it holds the same general programming ideas and was really easy to understand. Keep up the good work. On Mar 8, 2016 8:17 AM, "Lau Cheuk Yin" notifications@github.com wrote:
Thanks for giving a try on my plugin and having time to make pull request ;) Pull Request #2 https://github.com/tomlau10/gcc-make-run/pull/2 @Adobe-Android https://github.com/Adobe-Android
— Reply to this email directly or view it on GitHub https://github.com/tomlau10/gcc-make-run/issues/1#issuecomment-193799843 .
Oh just now I forgot to test it with the language-cpp14 plugin, and now I found that actually one more line needs to be added. I will push a fix soon.
Fixed with commit 9238350184c5ebbc1dd5972307ebd92aa4d77989
Okay cool. I'll test it sometime later and I look forward to seeing the changes. On Mar 8, 2016 10:35 AM, "Lau Cheuk Yin" notifications@github.com wrote:
Oh just now I forgot to test it with the language-cpp14 plugin, and now I found that actually one more line needs to be added. I will push a fix soon.
— Reply to this email directly or view it on GitHub https://github.com/tomlau10/gcc-make-run/issues/1#issuecomment-193852745 .
I haven't given a look at the code, but it seems like you have hard file names set for .c, .cpp, and makefiles. Unfortunately, when Atom auto-detects C++14 compliant code, your amazing plugin breaks (I'm being serious here, I really do love it). If you could fix this, I'd appreciate it a lot (This might also occur for other standards too, but I haven't looked into it). Thanks. Edit: Took a look at it and forked it. I'll send at least one fix. Also, this seems to occur due to the "Language Cpp14" plugin.