#10 Android support

[k0sukey]

• platform options and device id

$ triple --ios
$ triple --ios 'iPhone Retina (4 inch)'
$ triple --android
$ triple --android 'Google Nexus S - 4.1.1 - API 16 - 480x800'

$ triple --ios 'iPhone Retina (4 inch)' --android 'Google Nexus S - 4.1.1 - API 16 - 480x800'

• auto detect host ip address
• auto detect available port
• synchronized client response

[tonylukasavage]

There's a lot of problems with this PR, to the point that it's pretty unreviewable. In most cases, if a PR doesn't meet the standards to be merged immediately, I work with it until it does, but this is just way too much work that changes massive chunks of the module with no accompanying testing to assert that these massive changes haven't broken lots of things.

• You apparently have different code formatting that you applied to a lot of these files, so now stuff like whitespace you've added (or maybe you use spaces instead of tabs) is causing almost the entire project to look like its been changed. This makes it impossible to review.
• The PR itself is just way too big, adding multiple dependencies, and looking a lot more complicated than I would have expected. This issue was a placeholder for Android support, it was not meant to house every single possible issue associated with it. Break the improvements into reviewable sized portions rather than cramming them all in here.
• A specific example of the above is that running both ios and android at the same time is way outside the scope of this issue. That, among other things you changed, needs to be detailed in its own ticket and resolvd with a much smaller, manageable PR.
• I don't like the specific flags for iOS and android. Then we need to add more whenever a new platform comes on. It makes a lot more sense to have a single -p, --platform <platform> flag.
• I don't like the inclusion of tcptest for finding ports. I'd rather just allow the developer to specify a port, -P, --port <port>
• I don't like the inclusion of ip, since all it appears to do is determine the IP of the server, which is already handled in the constants.js file.
• You should squash the commits so there's not so much to go through

Also, just a heads up, I noted in the original issue that I'm not adding Android support until 0.3.0 in order to get the new features for iOS released. Even with fixing the above it will need to wait to be merged until after the 0.3.0-dev branch starts.

After having said all that, I really am impressed by the amount of work and really want to get you on board as a contributor, we just need to dial down the scope and break it into smaller issues so that the current stability and user experience can be preserved.

[k0sukey]

Thanks for your comment. And sorry for too much stuffing function. The finely divided once, could you be PR again? (-P, --port <port>, etc...)

Of course, I will wait until 0.3.0 for Android support. Has become doing. Inserting different.

[tonylukasavage]

Resolved in #10, but thank you for the initial work on this! Much appreciated!