Closed maxceem closed 3 years ago
✅ Selecting some week, clicking the dates again should close calendar. currently, just select the week, it will close it. ✅ select week '11/14 - 11/20', when open the week select model, it still show month as May. ✅ Fix lint issues https://monosnap.com/file/JA2jyB9lOi87OSszgARXV3u8kXmwKn ✅ https://monosnap.com/file/8lcYMuEkmFL4Zj8zaOMhLP27axaeAg "If server returns "null" in "daysWorked" field, we should show 5 (default value)." When server return 0, UI should show 0 instead of 5. ✅ https://monosnap.com/file/QvOrSBWF9hyra0Jgx6sEoGQamZSpRA There should be space between table row and card border ✅ Handle text should be blue ✅ There should be a line between "freelancers" and search box in sidebar ✅ https://monosnap.com/file/Pu0a9TvChhW033iOZdubeH9RJfnl0Z "taas app" in readme should be updated to "taas admin app"., see https://monosnap.com/file/BGmZsrRsqUInAhNUo7jYKlKyubg6TH and https://monosnap.com/file/Om836YFSsw2EcsKG1x9uyL9ASXm65o and all other similar places. Pagination button colors doesn't match design https://monosnap.com/file/fpMOZDFbyVTxkGnTj3vGqBLThWmoO6 ✅ Calendar should not have arrow as per design https://monosnap.com/file/KhuMCV0aWVAHW9Vwh3UHcwtItjd7Am ✅ In calendar year list button to scroll up/down should show green arrows so we know that we can scroll the list https://monosnap.com/file/wYounMTrS0kvKLiuRc14J81npk5W9C ✅PerPage selector should not go on top of the menu https://monosnap.com/file/lOMWpPOtjOOhXLAuurxHDFuWubTLTY. Can we fix it inside the Admin App without updating the Navbar app? ✅Label style doesn't match design https://monosnap.com/file/OZ7wNIslUT8BoKNYKIZlrx9EGjHHXQ (font is too big, maybe something else, need to check all the styles). ✅When put cursor on top of the dates the cursor should become "hand" so we know that we can click it https://monosnap.com/file/qBiiVweVB80nUkxPkZ38B2HLKLEX9K ✅Max possible value in Days Worked should be 5 https://monosnap.com/file/89HRRgoLAXK9X3kPQbQpjJ6fUxi00F ✅Make all the corners of the content block "round" like in design and add space below the table like in design https://monosnap.com/file/VoEhivXPBNkm4263xGq3PjQUGfDPi4 Remove all the PNG files, we should only use SVG. ✅ Add a lint rule to not allow unused variables/arguments https://eslint.org/docs/rules/no-unused-vars and fix lint errors in code after this. You may choose an appropriate rule config so we don't have to disable this lint rule in code. ✅ Complete documentation comments for all the component https://github.com/topcoder-platform/micro-frontends-taas-admin-app/blob/feature/basic-work-periods/src/components/WeekPicker/index.jsx#L11-L22 this one and all other where comments docs are not added or not completed. In "src/components" and in "routes/WorkPeriods/components" folders. ✅ The URL for the page with WorkPeriods would be "/taas-admin/work-periods". URL "/taas-admin/" should redirect to "/taas-admin/work-periods" similar to the TaaS App. ✅ Comment "payment status" filter for now. As it doesn't work just hide it, but don't remove anything. ✅ Inside the Earn app the same layout is implemented without using global style for html. The reason why I'd like to avoid it is because we are using MFE architecture and it's better not to make any changes into the common elements like html, body and so on. We should only change styles inside the TaaS Admin App container single-spa-application:@topcoder/micro-frontends-taas-admin-app. ✅Prevented wrapping of team name, payment status and start/end dates. ✅Sidebar should take full width on the small screens https://monosnap.com/file/KEff8AYzzQ2QEGLgfX0Jhy5zV6Gcic
✅ Selecting some week, clicking the dates again should close calendar. currently, just select the week, it will close it. ✅ select week '11/14 - 11/20', when open the week select model, it still show month as May. ✅ Fix lint issues https://monosnap.com/file/JA2jyB9lOi87OSszgARXV3u8kXmwKn ✅ https://monosnap.com/file/8lcYMuEkmFL4Zj8zaOMhLP27axaeAg "If server returns "null" in "daysWorked" field, we should show 5 (default value)." When server return 0, UI should show 0 instead of 5. ✅ https://monosnap.com/file/QvOrSBWF9hyra0Jgx6sEoGQamZSpRA There should be space between table row and card border ✅ Handle text should be blue ✅ There should be a line between "freelancers" and search box in sidebar ✅ https://monosnap.com/file/Pu0a9TvChhW033iOZdubeH9RJfnl0Z "taas app" in readme should be updated to "taas admin app"., see https://monosnap.com/file/BGmZsrRsqUInAhNUo7jYKlKyubg6TH and https://monosnap.com/file/Om836YFSsw2EcsKG1x9uyL9ASXm65o and all other similar places. Pagination button colors doesn't match design https://monosnap.com/file/fpMOZDFbyVTxkGnTj3vGqBLThWmoO6 ✅ Calendar should not have arrow as per design https://monosnap.com/file/KhuMCV0aWVAHW9Vwh3UHcwtItjd7Am ✅ In calendar year list button to scroll up/down should show green arrows so we know that we can scroll the list https://monosnap.com/file/wYounMTrS0kvKLiuRc14J81npk5W9C ✅PerPage selector should not go on top of the menu https://monosnap.com/file/lOMWpPOtjOOhXLAuurxHDFuWubTLTY. Can we fix it inside the Admin App without updating the Navbar app? ✅Label style doesn't match design https://monosnap.com/file/OZ7wNIslUT8BoKNYKIZlrx9EGjHHXQ (font is too big, maybe something else, need to check all the styles). ✅When put cursor on top of the dates the cursor should become "hand" so we know that we can click it https://monosnap.com/file/qBiiVweVB80nUkxPkZ38B2HLKLEX9K ✅Max possible value in Days Worked should be 5 https://monosnap.com/file/89HRRgoLAXK9X3kPQbQpjJ6fUxi00F ✅Make all the corners of the content block "round" like in design and add space below the table like in design https://monosnap.com/file/VoEhivXPBNkm4263xGq3PjQUGfDPi4 Remove all the PNG files, we should only use SVG. ✅ Add a lint rule to not allow unused variables/arguments https://eslint.org/docs/rules/no-unused-vars and fix lint errors in code after this. You may choose an appropriate rule config so we don't have to disable this lint rule in code. ✅ Complete documentation comments for all the component https://github.com/topcoder-platform/micro-frontends-taas-admin-app/blob/feature/basic-work-periods/src/components/WeekPicker/index.jsx#L11-L22 this one and all other where comments docs are not added or not completed. In "src/components" and in "routes/WorkPeriods/components" folders. ✅ The URL for the page with WorkPeriods would be "/taas-admin/work-periods". URL "/taas-admin/" should redirect to "/taas-admin/work-periods" similar to the TaaS App. ✅ Comment "payment status" filter for now. As it doesn't work just hide it, but don't remove anything. ✅ Inside the Earn app the same layout is implemented without using global style for html. The reason why I'd like to avoid it is because we are using MFE architecture and it's better not to make any changes into the common elements like html, body and so on. We should only change styles inside the TaaS Admin App container single-spa-application:@topcoder/micro-frontends-taas-admin-app. ✅Prevented wrapping of team name, payment status and start/end dates. ✅Sidebar should take full width on the small screens https://monosnap.com/file/KEff8AYzzQ2QEGLgfX0Jhy5zV6Gcic