search

topcoder-platform / micro-frontends-taas-admin-app

taas-admin-app for managing taas administrative activities
MIT License
0 stars 5 forks source link

Booking Manager role permission issues #51

Open sandhiyakavi opened 3 years ago

sandhiyakavi commented 3 years ago

Description:

Booking Manager has some minor permission issues in Taas Admin app.

  1. The suggestions are not getting listed for the Search by Topcoder handle.

image

  1. The Billing Account of the Resource if not set is displayed as "" and if already assigned, it's getting displayed in red colour. Also the BA suggestion from Project level is not getting displayed.

image image

image image

maxceem commented 3 years ago

@sandhiyakavi unfortunatelly we cannot fix these issue on the TaaS side, because both of them happens due to 3rd party API which doesn't allow Booking Managers some operations.

  1. We use endpoint GET /v3/members/_suggest/ to get member suggestions. This endpoint doesn't return suggestions to Booking Manager users. That's why we cannot show them. There are 2 possible solutions:

    1. Ask owner of the Member Service to allow Bookings Managers to get suggsetions.
    2. Create a proxy endpoint in TaaS API which would internally call Member Service using M2M token, and allow Bookings Managers to get the suggestions

  2. To get the list of Billing Accounts here, we use API endpoints from the Projects API https://api.topcoder-dev.com/v5/projects/17266/billingAccounts. This endpoint has very tricky logic regarding what BAs are returned there.

    • User would return the list of the billing account from SDFC to which user has access to

    • BUT to be able to get this list the user MUST be a member of the Topcoder Team or Copilot or Administrator.

      • As a result, Booking Manager users would NOT get any billing accounts unless they join Connect Project "Topcoder Team".
      • Admin users can still get BAs without joining.

      image

    • The only solution here would be to update endpoint to allow Booking Managers to get billing accounts without joining. Vikas Agarwal might help with this as he is owner of this part.

cc @nkumar-topcoder fixing this issue most likely would require discussing it other Topcoder teams, so I guess only you could help here and decide on how to deal with it.

maxceem commented 3 years ago

For the first part we are going to create a proxy endpoint via https://github.com/topcoder-platform/taas-apis/issues/390