tophatter / facebook-ruby-ads-sdk

The Facebook Marketing API in Ruby.
https://developers.facebook.com/docs/marketing-apis
MIT License
62 stars 39 forks source link

Add manual bid support #17

Closed tfe closed 7 years ago

tfe commented 7 years ago

⚠️ This does include a breaking API change. ⚠️

Generally adds ability to pass bid_amount parameter when creating ad sets.

But also changes ad set is_autobid parameter default to nil (was true). This is a breaking change for current users of this library, but I think it's essential for moving forward. Rationale:

Normally a breaking change like this would require a major version number increment, but since we're on major version 0 the public API is not expected to be stable, so I plan to just bump the minor version number.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 73.946% when pulling e3c32167a267b67c633850a802f55729c6946222 on add-manual-bid-support into 74057d52b4c8535d61f2b5fc8b6435753ab878c4 on master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 73.755% when pulling 1431a0965c3f136833c462b75f51e37d97ab783c on add-manual-bid-support into 74057d52b4c8535d61f2b5fc8b6435753ab878c4 on master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 73.946% when pulling fe5bc5cac284d3e0066f0c43d239b2fab83eca7b on add-manual-bid-support into 74057d52b4c8535d61f2b5fc8b6435753ab878c4 on master.