API version update + expansions to Ad Campaign/Ad Set/Ad Targeting

tophatter / facebook-ruby-ads-sdk

The Facebook Marketing API in Ruby.

https://developers.facebook.com/docs/marketing-apis

MIT License

62 stars 39 forks source link

API version update + expansions to Ad Campaign/Ad Set/Ad Targeting #18

Closed icole closed 7 years ago

icole commented 7 years ago

I know there are quite a few modifications here in one, so if you need I can split this out into separate feature branches and PR's. Here is a list of the following key things I have updated to expand functionality to support different Marketing API use cases.

Update default API version to 2.9 since 2.8 is now deprecated
Allow for lat/long or address targeting via custom locations
Add income as an audience targeting param
Add support for new delivery_estimate endpoint added in 2.9
Add support for lifetime budgets on ad sets
Remove a new deprecated field on ad creatives
Allow for support of Link Ad Creatives

If there are any modifications of additions you would like I am happy to do that if you could please just let me know.

coveralls commented 7 years ago

Coverage decreased (-11.03%) to 62.917% when pulling 0685c72ddc5947950461efd92af7a06928d31ae6 on icole:develop into 1c0e1420c5dda5b9c2ada4c75ce95e9d1fbdf45d on tophatter:master.

icole commented 7 years ago

FYI I will be fixing the tests and adding any new tests to support this new code.

cte commented 7 years ago

Awesome 👏

coveralls commented 7 years ago

Coverage decreased (-2.2%) to 71.705% when pulling 2e970ae5d216d0e66328832a9af1e8079c257ab1 on icole:develop into 1c0e1420c5dda5b9c2ada4c75ce95e9d1fbdf45d on tophatter:master.

coveralls commented 7 years ago

Coverage decreased (-2.2%) to 71.705% when pulling 45ddd8061d2be4efc43761b2172a410d64f38ff8 on icole:develop into 1c0e1420c5dda5b9c2ada4c75ce95e9d1fbdf45d on tophatter:master.

coveralls commented 7 years ago

Coverage increased (+3.04%) to 76.987% when pulling 9da257622e5e317e20c0fc23174efba16c0529df on icole:develop into 1c0e1420c5dda5b9c2ada4c75ce95e9d1fbdf45d on tophatter:master.

coveralls commented 7 years ago

Coverage increased (+3.04%) to 76.987% when pulling 687e5318c160fe6f3d49bcbc5ceb516378a9f463 on icole:develop into 1c0e1420c5dda5b9c2ada4c75ce95e9d1fbdf45d on tophatter:master.

icole commented 7 years ago

@cte, or any maintainer, could you take a look at this and let me know if it looks good? Happy to change anything as necessary.

cte commented 7 years ago

👍 from me. Can you update the version in facebook_ads.gemspec? I'll merge it after that. Thanks @icole.

icole commented 7 years ago

@cte Updated version. Thanks!

coveralls commented 7 years ago

Coverage increased (+3.0%) to 76.898% when pulling f676e06f1b7beb338e4a8e187c27a908a921206e on icole:develop into 1c0e1420c5dda5b9c2ada4c75ce95e9d1fbdf45d on tophatter:master.

coveralls commented 7 years ago

Coverage increased (+3.0%) to 76.898% when pulling 87b6a016739355b3fce42d5127645ba9d9defea9 on icole:develop into 1c0e1420c5dda5b9c2ada4c75ce95e9d1fbdf45d on tophatter:master.