search

tophatter / facebook-ruby-ads-sdk

The Facebook Marketing API in Ruby.
https://developers.facebook.com/docs/marketing-apis
MIT License
62 stars 39 forks source link

Add reachestimate for Ad Account #5

Closed icole closed 7 years ago

icole commented 7 years ago

I have a need to query /reachestimate for a particular ad account (https://developers.facebook.com/docs/marketing-api/reference/ad-account/reachestimate/v2.8).

One issue I had was with several dependencies on the activesupport gem so I added that as a gem dependency, since right now I am running it outside of a Rails project.

Please critic and let me know if I missed the mark on anything!

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.7%) to 66.832% when pulling 7d2fcc371c298149de50852a84c052c3b8e30c63 on icole:master into 1bea1fe42136d54e7337590a39457d6ff547417f on cte:master.

cte commented 7 years ago

Thanks for the PR. Will check it out shortly.

cte commented 7 years ago

Added here: https://github.com/cte/facebook-ruby-ads-sdk/commit/ae35878e584ceb4d18ea353cfe7f658f54d7d85f

I prefer not to depend on active_support in this gem.

icole commented 7 years ago

@cte, Understandable, FYI I would have happily refactored out the active support stuff if you had asked. I was really hoping to get more public code contributions on my GitHub. Thanks for implementing anyway. Also, could you please add the additional goals here? (https://github.com/cte/facebook-ruby-ads-sdk/blob/master/lib/facebook_ads/ad_set.rb#L36)

cte commented 7 years ago

That's awesome thanks!

Here you go: https://github.com/cte/facebook-ruby-ads-sdk/pull/9