Change to_sentence calls to join(', ')

tophatter / facebook-ruby-ads-sdk

The Facebook Marketing API in Ruby.

https://developers.facebook.com/docs/marketing-apis

MIT License

62 stars 39 forks source link

Change to_sentence calls to join(', ') #7

Closed dekaikiwi closed 7 years ago

dekaikiwi commented 7 years ago

Array.to_sentence is a Rails string method thus will throw an error when used in vanilla Ruby

/facebook_ads-0.1.11/lib/facebook_ads/ad_account.rb:28:in `create_ad_campaign': undefined method `to_sentence' for ["CONVERSIONS", "MOBILE_APP_INSTALLS"]:Array (NoMethodError)

The same is achievable with the .join method.

I've updated references of to_sentence to join(', ') in this PR

coveralls commented 7 years ago

Coverage remained the same at 67.506% when pulling 070a3256e628ddc23c1e69083c949c6e8dcfaed9 on dekaikiwi:fix/chance-to-sentence-to-join into 1bea1fe42136d54e7337590a39457d6ff547417f on cte:master.