topjohnwu / Magisk

The Magic Mask for Android
GNU General Public License v3.0
47.88k stars 12.15k forks source link

Do Not Submit MagiskHide Requests #1152

Closed topjohnwu closed 4 years ago

topjohnwu commented 5 years ago

Any further "MagiskHide" and related root hiding development will no longer be in the official Magisk repo and will not be done by topjohnwu, so all Issues along these lines will be immediately closed.

See: https://topjohnwu.medium.com/state-of-magisk-2021-fe29fdaee458 And: https://twitter.com/osm0sis/status/1431948577627119618


You may check this unofficial off-site documentation for any updates going forward: https://www.didgeridoohan.com/magisk/MagiskHide

nduyhien commented 4 years ago

https://play.google.com/store/apps/details?id=com.irdeto.kplus MyK+ app does not work after Magisk v20. I uninstalled MyK+ app, uninstalled Magisk, rebooted, installed Magisk v20, rebooted into system, installed Magisk Manager 7.3.5. Then i have installed MyK+ from Play Store, but still same issue. Please give advice for this case. Thank all!

arjunkatwal24 commented 4 years ago

I just read Best Practices for MagiskHide but it didn't help me out. I saw you have written Report to me and I will hack up a solution ASAP. So here is the app: https://play.google.com/store/apps/details?id=com.vokal.dscout dscout app detects root despite following all the methods. Magisk Version 20.1 & Magisk Manager 7.4.0. Thank You!

DenyDarko commented 4 years ago

No it does not. This before hiding: Screenshot_20191104-072924

This is after. Normal launch.

Screenshot_20191104-072955

arjunkatwal24 commented 4 years ago

But it keeps crashing on my device. And, are you testing it on Stock Rom? Also, the app works at first launch but once we close the app from the background, it will force close like above.

Screenshot_20191024-234101

snake696 commented 4 years ago

Please help me. I want to install Magisk on fujitsu's F-04G, but F-04G does not have boot loader mode or TWRP. Can you tell me how to install Magisk on F-04G?

androidacy-user commented 4 years ago

@snake696 this issue is not the place to ask. Go ask in Q&A on XDA

Tkkg1994 commented 4 years ago

As we should not open any new issues upon magisk hide I will leave a comment here: Since the last update of my banking app it somehow detects magisk. What I've tried is:

Because all these things won't help to get the app to work, I'm sure they have a new method to track down the process of magisk itself. If anyone wants to try the app on his own phone, here is the link: https://play.google.com/store/apps/details?id=com.ubs.swidK2Y.android&referrer=utm_source%3Daccessapp_productpage

If any logs can be provided to solve the issue, let me know!

androidacy-user commented 4 years ago

@Tkkg1994 not sure if you actually have to sign in to get the detection but I had zero issues.

Setup: Pixel 2 XL running Pixel Dust X Using props module to pass CTS Using stub manager apk, also hidden MagiskHide on the app Development options on, usb debugging off

MikuDroid commented 4 years ago

As we should not open any new issues upon magisk hide I will leave a comment here: Since the last update of my banking app it somehow detects magisk. What I've tried is:

  • Uninstall the manager apk, still detects root
  • Disable usb debugging, still detects root
  • Disable developer mode, still detects root

Because all these things won't help to get the app to work, I'm sure they have a new method to track down the process of magisk itself. If anyone wants to try the app on his own phone, here is the link: https://play.google.com/store/apps/details?id=com.ubs.swidK2Y.android&referrer=utm_source%3Daccessapp_productpage

If any logs can be provided to solve the issue, let me know!

Some apps need to be logged in first to detects whether the device is rooted or not. Your app is similar to Grab Driver when it comes to detects the device.

Tkkg1994 commented 4 years ago

@Tkkg1994 not sure if you actually have to sign in to get the detection but I had zero issues.

Setup: Pixel 2 XL running Pixel Dust X Using props module to pass CTS Using stub manager apk, also hidden MagiskHide on the app Development options on, usb debugging off

I deleted all app data to simulate the new install and the pop up was there right away. I can't even sign in with the rooted phone. So how the fuck does this work for you. I've tried it on 3 devices now:

I have to find out what you've done to pass the check! Because my device was working till the company updated the app like a week ago.

As we should not open any new issues upon magisk hide I will leave a comment here: Since the last update of my banking app it somehow detects magisk. What I've tried is:

  • Uninstall the manager apk, still detects root
  • Disable usb debugging, still detects root
  • Disable developer mode, still detects root

Because all these things won't help to get the app to work, I'm sure they have a new method to track down the process of magisk itself. If anyone wants to try the app on his own phone, here is the link: https://play.google.com/store/apps/details?id=com.ubs.swidK2Y.android&referrer=utm_source%3Daccessapp_productpage If any logs can be provided to solve the issue, let me know!

Some apps need to be logged in first to detects whether the device is rooted or not. Your app is similar to Grab Driver when it comes to detects the device.

It detects right away you don't have to login first

hexdra commented 4 years ago

@Tkkg1994 not sure if you actually have to sign in to get the detection but I had zero issues. Setup: Pixel 2 XL running Pixel Dust X Using props module to pass CTS Using stub manager apk, also hidden MagiskHide on the app Development options on, usb debugging off

I deleted all app data to simulate the new install and the pop up was there right away. I can't even sign in with the rooted phone. So how the fuck does this work for you. I've tried it on 3 devices now:

* Nexus 5X with lineageos, latest Magisk + Manager hidden + safetynet pass

* Galaxy S10+ with stock rom, latest Magisk + Manager hidden + safetynet pass

* OnePlus 7 with stock rom, latest Magisk + Manager hidden + safetynet pass
  (I tried it with core mode only as well... doesn't help)

I have to find out what you've done to pass the check! Because my device was working till the company updated the app like a week ago.

As we should not open any new issues upon magisk hide I will leave a comment here: Since the last update of my banking app it somehow detects magisk. What I've tried is:

  • Uninstall the manager apk, still detects root
  • Disable usb debugging, still detects root
  • Disable developer mode, still detects root

Because all these things won't help to get the app to work, I'm sure they have a new method to track down the process of magisk itself. If anyone wants to try the app on his own phone, here is the link: https://play.google.com/store/apps/details?id=com.ubs.swidK2Y.android&referrer=utm_source%3Daccessapp_productpage If any logs can be provided to solve the issue, let me know!

Some apps need to be logged in first to detects whether the device is rooted or not. Your app is similar to Grab Driver when it comes to detects the device.

It detects right away you don't have to login first

I tested it too, working great after i added the App to magisk hide. Did u do that? Also dont move the app to sd Card, because magisk hide isnt working then. Maybe it scans for magisk files on your storage (.zip files...).

Tkkg1994 commented 4 years ago

@Tkkg1994 not sure if you actually have to sign in to get the detection but I had zero issues. Setup: Pixel 2 XL running Pixel Dust X Using props module to pass CTS Using stub manager apk, also hidden MagiskHide on the app Development options on, usb debugging off

I deleted all app data to simulate the new install and the pop up was there right away. I can't even sign in with the rooted phone. So how the fuck does this work for you. I've tried it on 3 devices now:

* Nexus 5X with lineageos, latest Magisk + Manager hidden + safetynet pass

* Galaxy S10+ with stock rom, latest Magisk + Manager hidden + safetynet pass

* OnePlus 7 with stock rom, latest Magisk + Manager hidden + safetynet pass
  (I tried it with core mode only as well... doesn't help)

I have to find out what you've done to pass the check! Because my device was working till the company updated the app like a week ago.

As we should not open any new issues upon magisk hide I will leave a comment here: Since the last update of my banking app it somehow detects magisk. What I've tried is:

  • Uninstall the manager apk, still detects root
  • Disable usb debugging, still detects root
  • Disable developer mode, still detects root

Because all these things won't help to get the app to work, I'm sure they have a new method to track down the process of magisk itself. If anyone wants to try the app on his own phone, here is the link: https://play.google.com/store/apps/details?id=com.ubs.swidK2Y.android&referrer=utm_source%3Daccessapp_productpage If any logs can be provided to solve the issue, let me know!

Some apps need to be logged in first to detects whether the device is rooted or not. Your app is similar to Grab Driver when it comes to detects the device.

It detects right away you don't have to login first

I tested it too, working great after i added the App to magisk hide. Did u do that? Also dont move the app to sd Card, because magisk hide isnt working then. Maybe it scans for magisk files on your storage (.zip files...).

What's the app version you are using to test it? Mine is 3.7.9.0. If it's a different one that would explain why it works. In this case can you send the apk? I would love to compare both of them to see what they changed. Otherwise: Nope I have no magisk files on my phne, everything is hidden and magisk works fine. And nope the app isn't installed on the SD card

hexdra commented 4 years ago

@Tkkg1994 Its the same version 3.7.9.0. Is everything fine when you test your device with Rootbeerfresh? https://play.google.com/store/apps/details?id=com.kimchangyoun.rootbeerFresh.sample

Tkkg1994 commented 4 years ago

@Tkkg1994 Its the same version 3.7.9.0. Is everything fine when you test your device with Rootbeerfresh? https://play.google.com/store/apps/details?id=com.kimchangyoun.rootbeerFresh.sample

Screenshot_20191216-141021_RootbeerFresh

Could it be that magisk hide is not fast enough to hide root infront of the app before it does its check?

Polve commented 4 years ago

I have the same problem: at a certain point (I think after last magisk update), two phones (one is Nexus 5X, the other is Pixel XL) are not able to pass safetynet anymore.

I'm using LineageOs, magisk tells me that BasicIntegrity is ok, btsProfile is false.

RootBeerFresh gives me the same results of the post above mine, with all green checks.

Any hints?

robertototaro commented 4 years ago

@topjohnwu I just submitted a new issues (#2163) and then I saw this one. My question is: how can I give you insights on a new detection method if I am not an advanced Android developer? The only thing I can do is tell you that a certain app does not work even after I followed your best practices for Magisk Hide, then hope that you can test it. I can certainly provide logs, if you tell me what you need. I simply do not have the know-how to find out what these apps are doing to detect root.

So... I decided to open anyway a new issue and ask you if I can somehow provide more info.

robertototaro commented 4 years ago

As we should not open any new issues upon magisk hide I will leave a comment here: Since the last update of my banking app it somehow detects magisk. What I've tried is:

  • Uninstall the manager apk, still detects root
  • Disable usb debugging, still detects root
  • Disable developer mode, still detects root

Because all these things won't help to get the app to work, I'm sure they have a new method to track down the process of magisk itself. If anyone wants to try the app on his own phone, here is the link: https://play.google.com/store/apps/details?id=com.ubs.swidK2Y.android&referrer=utm_source%3Daccessapp_productpage

If any logs can be provided to solve the issue, let me know!

I can confirm the problem with this app and its companion "UBS Mobile Banking". They only work once one removes Magisk completely. Nothing else works. I opened a new issue (#2163) that I guess will end up merged in this thread.

matco commented 4 years ago

Same here with the "UBS Access" application.

mightysashiman commented 4 years ago

Same issue with "UBS Access" application too. I know you'll be closing it also citing #1152, but please take a minute here : I did follow your best practice tutorial. Magisk stealth methods did managed some time ago to hide from this app ; "UBS access" dev team must have found a new detection method and are playing cat & mouse with your efforts. Unfortunately, in this game, YOU are the expert, we rely on your good will and technical knowledge. The simple fact you did implement some form of anti-detection features means you are completely oblivious to the problem. The only thing we users (who really appreciate your work by the way) can do is report that this app is detecting magisk. If you have any idea how we can send you technical feedback (magisk logs if magisk picks up anything, maybe memory dumps of some kind of the problematic app...) instead of just closing our comments in a "fuck off" fashion, please add stuff to your tutorial so we non-android-hackers may help you as much as we can. Please. Thanks in advance.

manofsteel2017 commented 4 years ago

Hey guys, seems like spay for gear is now seeing root

I ran the root beer app Seems. To have mad red x I'm not sure what most are lol. Maybe you guys can tell me how to make them all green

Screenshot_20200226-073316_RootbeerFresh

manofsteel2017 commented 4 years ago

I fixed it. Hide the app and rename magisk And added the uds bypass set permission 0755 and reboot.

Spay is working And everything is green

kgptzac commented 4 years ago

MagiskHide should also stop apps from detecting Developer Mode and USB Debugging options being turned on. This comes from someone didn't realize turning off Developer Mode would result in turning of OEM Unlock and would in turn renders the system unbootable.

Didgeridoohan commented 4 years ago

@kgptzac Magisk can't do that. It can change the props for it, yes, but that would be the same as turning them off yourself. To leave those option enabled, but make it seem like they're not you need something like Xposed.

androidacy-user commented 4 years ago

@kgptzac Magisk can't do that. It can change the props for it, yes, but that would be the same as turning them off yourself. To leave those option enabled, but make it seem like they're not you need something like Xposed.

There's a specific Xposed module for that; however it can cause the same issue because it even hides the debugging from Android lol

topjohnwu commented 4 years ago

SafetyNet is done :D

Pheromon commented 4 years ago

SafetyNet is done :D

What do you mean?

Didgeridoohan commented 4 years ago

Check John's Twitter.

Pheromon commented 4 years ago

WTH more than magisk, the whole ecosystem of alternate releases as LineageOs are fucked for good now

Didgeridoohan commented 4 years ago

No. You can still unlock your phone and use custom ROMs, just not hide the fact.

androidacy-user commented 4 years ago

No. You can still unlock your phone and use custom ROMs, just not hide the fact.

Let us not forget 2 out of every 3 apps on the Play store have some sort of SafetyNet or bootloader unlock check. Meaning sure you can use the ROM, just you're going to be very limited in what apps you can use. Still unsure to this day why a SMS app needs a SafetyNet check but that just proves many app developer unnecessarily (ab)use such checks.

Pheromon commented 4 years ago

No. You can still unlock your phone and use custom ROMs, just not hide the fact.

No, I can't because most of banking applications needs to pass the safety check, otherwise they don't start.

androidacy-user commented 4 years ago

Mind you I'm rocking a OnePlus device right now so I'm unaffected thank God

khalidaboelmagd commented 4 years ago

ad.gov.adpolice package https://play.google.com/store/apps/details?id=ae.gov.adpolice&hl=en

hide not working..i've hided the app and renamed Magisk and still app detected root

oneplus 7 pro with android 9

Sap1k commented 4 years ago

As of today, CTS started magically passing again. Seems like Google reverted the changes for now. Tried on a few Custom ROM's and stock (Android 9&10), all rooted with Magisk 20.3, and all pass CTS. The Custom ROM's had March patches.

Justsnoopy30 commented 4 years ago

As of today, CTS started magically passing again. Seems like Google reverted the changes for now. Tried on a few Custom ROM's and stock (Android 9&10), all rooted with Magisk 20.3, and all pass CTS. The Custom ROM's had March patches.

Confirmed on my Google Pixel 3 XL.

Polve commented 4 years ago

No luck on my pixel xl :-( , CTS profile is not passing since longtime

Sap1k commented 4 years ago

@Polve If it didn't work before (in February) it won't work now, but if it did, it should work again

khalidaboelmagd commented 4 years ago

ad.gov.adpolice package https://play.google.com/store/apps/details?id=ae.gov.adpolice&hl=en

hide not working..i've hided the app and renamed Magisk and still app detected root

oneplus 7 pro with android 9

It was due to busybox binary

dundunn commented 4 years ago

Unless you provide any insights on a new detection method, all MagiskHide related requests will be ignored. 99% of the time, you are not following the best practices for MagiskHide, please check my official tutorial. https://topjohnwu.github.io/Magisk/tutorials.html#best-practices-for-magiskhide

That Github page doesn't exist anymore or is currently private.

Like nearly all Github pages nowadays...

freddiN commented 4 years ago

DKB-Tan2go (bankin app) detects root since the latest 2.5.1 update (discussion here: https://forum.xda-developers.com/android/help/dkb-tan2go-app-rooted-device-t3835355). For now we are sticking with 2.5.0 which continues to work, at least for now.

Very strange, either they came up with a new detection method, or they detect other apps that can only be installed when root (so sort of an indirect detection).

Didgeridoohan commented 4 years ago

@freddiN If it's only detecting at start (force closing) then it is detecting something other than Magisk, yes. I just tested and can start v2.5.1 with no issue (app on the Hide list and hidden Manager).

If it hasn't been brought up in that thread already, take a look here for some tips: https://didgeridoohan.com/magisk/MagiskHide#hn_Hiding_root_from_apps

dundunn commented 4 years ago

I tried uninstalling all my apps that required root, reinstalled Tan2go, added it to Magisk Hide and yet it still gets detected. Simple solution someone was mentioning on XDA. Just use Island or an other virtualization App and use Tan2go with it.

Didgeridoohan commented 4 years ago

@dundunn It's not only about apps. It's also possible to detect files and folders on your device that hint at a rooted or otherwise modified device. The latest fad has been the TWRP directory on your internal storage. But all of this is mentioned in the link I posted above...

Of course, it might also be something completely different that's specific to your device/ROM/setup that I can't replicate.

dundunn commented 4 years ago

I rather wanted to point out that using MagiskHide with Tan2go doesn't make much sense anymore. It works with Island and should work with Shelter or other sandbox apps.

htfy96 commented 4 years ago

Since around two weeks ago, Duo always recognize my device as rooted on auth requests, and SafetyNet check starts to fail randomly even in Core mode:

Click to view screenrecord ![magisk-opt](https://user-images.githubusercontent.com/8121231/80324157-69386280-87fd-11ea-8f32-6a92e840fbbd.gif)

Using a third-party SafetyNet validator gives out the same result - sometimes the verification failed with:

Safety Net Request: success Response signature validation: fail (Response payload validation failed)

Flole998 commented 4 years ago

I am noticing on LineageOS 17.1 (Android 10) on my HTC One M8 that Magisk Hide doesn't seem to be working at all. RootBeer is detecting su for some reason, despite it is on the Hide-List and I even tried to disable and enable Magisk Hide but that didn't help. On my OnePlus 3 running Android 9 it is working perfectly fine so I think there might be something going on with Android 10 or that specific LineageOS Version. I didn't find anything except for #1823 which was closed for not providing enough information, but as I am running the same version of Magisk on both devices aswell as the same version of RootBeer I am more and more conviced that this is a bug. Any idea how I can further dig into this issue?

pandatabe commented 3 years ago

Unless you provide any insights on a new detection method, all MagiskHide related requests will be ignored.

99% of the time, you are not following the best practices for MagiskHide, please check this tutorial: https://www.didgeridoohan.com/magisk/MagiskHide

Unless you provide any insights on a new detection method, all MagiskHide related requests will be ignored.

99% of the time, you are not following the best practices for MagiskHide, please check this tutorial: https://www.didgeridoohan.com/magisk/MagiskHide

MisterMakerNL commented 3 years ago

My payment app was detecting root, but today I updated magisk hide and it worked again. Not sure what happened but thanks you for all your efforts in making our phones a bit more ours!

0x23marco commented 3 years ago

Same on current version of com.starfinanz.mobile.android.dkbpushtan. they now detect root although magisk hide and current canary is installed and properly in place, unfortunately.

3xploiton3 commented 3 years ago

https://play.google.com/store/apps/details?id=com.saltanera.hadits&hl=en&gl=US

they now detect root although magisk hide and current magisk stable is installed and properly in place, unfortunately.