tosuapp / tosu

Eponymous software for reading osu! memory (allows you to make stream/tournament/in-game overlays), accounting for most of gosumemory's issues (not exactly). Supports windows/linux!
https://tosu.app
GNU Lesser General Public License v3.0
160 stars 15 forks source link

Support beatmap converted on tourney client #200

Closed mas-alone closed 1 week ago

mas-alone commented 1 week ago

Is it possible to add ar.converted cs.converted od.converted hp.converted support for each tourney client?

Because some tournament now have mixed mod, ar/cs/od/hp may be different for each client

cyperdark commented 1 week ago

@KotRikD do you allow this?

cyperdark commented 1 week ago

and also provide usecase @mas-alone

mas-alone commented 1 week ago

and also provide usecase @mas-alone

Like... data.tourney[0].beatmap.stats.ar.converted ?

cyperdark commented 1 week ago

Usecase in terms of how you would use it in overlay or etc, or what you need it for

mas-alone commented 1 week ago

Usecase in terms of how you would use it in overlay or etc, or what you need it for

we hope to be able to display the correct od/ar/cs/hp for each tourney client individually  Because of the existence of mixed mod, We hope can read in the overlay to similar data.tourney[0].beatmap.stats.ar.converted values, so we can display the correct value in obs-overlay

KotRikD commented 1 week ago

Why you need beatmap stat for each client? Like beatmap is should be equal for each client isn't? If yes, use API v2, and data.beatmap.stats.ar.converted

UPD: I get it, lemme think

KotRikD commented 1 week ago

Okay, I think its possible, why not, will do a bit later

cyperdark commented 1 week ago

@mas-alone any other info besides, ar,cs,od,hp?

mas-alone commented 1 week ago

@mas-alone any other info besides, ar,cs,od,hp?

yes and stars? seems beatmap.stats.stars.total also need to support in tourney.
idk if is possible. In fact, different mods(e.g., tourney[0] applies HR and tourney[1] applies HD) vary only for cs, ar, od, hp and stars

cyperdark commented 1 week ago

@mas-alone test this build, does it look like what you wanted? https://github.com/tosuapp/tosu/actions/runs/11253233660/job/31288061903?pr=201

mas-alone commented 1 week ago

@mas-alone test this build, does it look like what you wanted? https://github.com/tosuapp/tosu/actions/runs/11253233660/job/31288061903?pr=201

thanks! it works flawlessly 09791a159799ad90487558535e518e52 455a6edf283c3696d6ec474a98dd47f7

cyperdark commented 1 week ago

nice, dong close issue, it'll be automatically closed on PR close