search

tosuapp / tosu

Eponymous software for reading osu! memory (allows you to make stream/tournament/in-game overlays), accounting for most of gosumemory's issues (not exactly). Supports windows/linux!
https://tosu.app
GNU Lesser General Public License v3.0
160 stars 15 forks source link

feat: Improve GitHub Workflow (deploy.yml) #72

Closed GabuTheDev closed 7 months ago

GabuTheDev commented 7 months ago

This PR changes the deploy & build workflow behaviour by restricting action path to client-related files. (+ some reformatting)

GabuTheDev commented 7 months ago

May need testing before merging to master. I'm not familiarized with GitHub Actions.

KotRikD commented 7 months ago

And probably need add to paths .github/workflows/**/* to test any changes in CI as in your PR

GabuTheDev commented 7 months ago

And probably need add to paths .github/workflows/**/* to test any changes in CI as in your PR

I do not think it's needed. There's no need for a build or deploy when editing .github/ since the files inside this directory are steps for the GitHub CI that are being run on their server, not in the client (.exe).

If you want to add testing to PRs you should add a separate workflow that specifically does that testing.

GabuTheDev commented 7 months ago

I can do a separate workflow specifically for testing PR changes (in a separate PR) if needed.