search

tpill90 / steam-lancache-prefill

CLI tool to automatically prime a Lancache with Steam games
https://tpill90.github.io/steam-lancache-prefill/
MIT License
297 stars 26 forks source link

prefill on already existing cached games #114

Closed ich777 closed 1 year ago

ich777 commented 2 years ago

Hi, first of all thank you for that wonderful piece of software... :)

I ran into an issue when running the command ./SteamPrefill prefil --recent on my Debian LXC container that it actually downloads the whole entire game from the Steam servers instead from the lancache (because the games where cached before) where on my PC it downloads the game just fine from my lancache.

I've also made sure that it can resolve and find the lancache in the network.

Here is a screenshot after running the command from above (my Internet is capped at 250Mbit/s down) so it is clearly loading it from their servers and I also noticed that SteamPrefill spits a message out something that it downloads it from the CDN but only really short so that I can barely read it before the download starts: image

After a short while I've aborted the download and tried it from my PC where you can see it is clearly downloading it from my lancache: image

I also checked the access logs where it says MISS when running over the SteamPrefill (10.0.0.4 is where SteamPrefill is on): image

And here you can see that it passes when downloading it from my PC (10.0.0.41 is my PC): image

I know that CrossCode is a small game and maybe not the best example.

EDIT: I've also now tried it from my Windows PC, this is when I start SteamPrefill (as you can see it's also capped at 250Mbit/s - so to speak directly from Steam): image

And this is when I download it from the same PC on Steam itself (clearly from lancache): image

Am I missing something here or is this just normal behavior?

tpill90 commented 2 years ago

Hi, thank you for such a detailed report!

No, this is not the expected behavior. When working as intended SteamPrefill should behave exactly like Steam does, in that a cached game will be downloaded only from the cache.

It turns out that several others ran into the exact same issue this morning which was caused by https://github.com/uklans/cache-domains/pull/197 being merged and released two days ago.

I've released https://github.com/tpill90/steam-lancache-prefill/releases/tag/v1.5.0 with the fix for this, which should have everything working as intended.

Since I've had a few other people test and prove the latest release as fixing this issue, I'm going to close it for now. If for any reason things still aren't working, please feel free to reopen.

ich777 commented 2 years ago

@tpill90 sorry that I got back late to you but this is not solved, can you please reopen the issue.

It is really frustrating for me when I saw that three games where updated at about the same time (which are about 300GB in size) and they are downloaded entirely from the lancache even if the update was only about 2GB in size.

Is this really expected behavior? For the time being I have sopped using prefill and yes I will have to stop using prefill entirely because this consumes more power and slows down my server - using lancache on a spinning drive (I/O wait).

tpill90 commented 2 years ago

Hi @ich77. I just want to clarify a few things. Was this issue ever resolved for you with previous updates? Or did it start happening again with a newer version?

Also it sounds like you're running prefill in a container, correct?

I will reopen this issue for now until we can figure out what's going on.

tpill90 commented 2 years ago

Also do you have Discord @ich777 , I would like to talk to you a little bit more in depth on this issue.

ich777 commented 2 years ago

@tpill90 sorry for the late response, I'm really busy lately, had to fix a few compilation issues for my Driver plugins on Unraid.

Sorry this was maybe the wrong issue to post in since my issue is a little different now. It downloads the already cached parts from the lancache as expected but my question would be if there is another way to save or at least a dummy file somehow what it already downloaded and only download the "new" update parts since in my opinion this is a huge waste of CPU cycles if a update from about 2GB is released and it has to pull 110GB from the lancache and produces every time the prefill runs huge I/O wait on my system (maybe because I am using a spinning HDD).

Yes, I have Discord too.

reg98643t commented 2 years ago

I just updated to the latest version and now I am experiencing this issue as well. Was working fine prior to update.

tpill90 commented 1 year ago

@reg98643t I'm going to break out your comment into its own issue, as I think the original issue has already been resolved. We can continue on the new issue.