tpill90 / steam-lancache-prefill

CLI tool to automatically prime a Lancache with Steam games
https://tpill90.github.io/steam-lancache-prefill/
MIT License
297 stars 26 forks source link

Log Timezone Incorrect #294

Closed Cpt-Echo closed 1 year ago

Cpt-Echo commented 1 year ago

Prefill not respecting the timezone in the container for its logs when started by Cron Timezone is defaulting to +0 UTC

Expected behaviour - Timezone is inherited from host server or can also be set with TZ environmental variable in docker run. Both options have been tried with no success. Other processes within the same container (e.g. Cron) do use the correct timezone. e.g. Cron is set to 2am to start prefill, Prefill starts correctly at 2am, however logs show 4pm (correct timezone is +10 UTC)

If Prefill is started manually through command line the logs do show the correct time. This is only a problem when process is started by Cron

Region - Australia Platform - Docker Discord - Cpt Echo#3755

tpill90 commented 1 year ago

I've figured out the issue with this, and it should be fixed in the next release. Adding -e TZ=Europe/London as an environment variable should now override correctly.

tpill90 commented 1 year ago

Released in v2.1.0

Cpt-Echo commented 1 year ago

Unfortunately this fix did not work. Log still defaulting to 0 UTC even with -e TZ=Australia/Sydney (+10 UTC) As can be seen in the log screenshot, CRON is set for 2am, and executes correctly at 2am (+10utc) , however logging shows 4pm the day prior (0 UTC)

image

tpill90 commented 1 year ago

Ah thanks for the screenshot, I think I see whats going on here. I made the fix in my Docker image, however you're using ich777's container which wouldn't have my fix in it.

@ich777 Could you take a look at this when you get a chance? I'm pretty sure that this issue can be resolved by doing the same fix that I did in this PR : https://github.com/tpill90/steam-lancache-prefill/pull/296/files

ich777 commented 1 year ago

@Cpt-Echo thanks for the report but I have to say, next time please use the support thread on the Unraid forums since this is my container.

Please update the container itself, I've now added tzdata and it should work as intended.

ich777 commented 1 year ago

@Cpt-Echo any update on this? Does it now work?

tpill90 commented 1 year ago

I'm going to close this out, and it can be reopened if the issue persists