search

traxium / tabtree

Tab Tree extension for Firefox
https://addons.mozilla.org/en-US/firefox/addon/tab-tree/
GNU General Public License v3.0
144 stars 30 forks source link

[Bug] Firefox audio / mute display cuts off tab titles #143

Open Luckz opened 8 years ago

Luckz commented 8 years ago

When the audio playing / mute icon appears for any tab, the titles of all tabs are cut off at the width the audio icon appears at.

Disabling the icon via browser.tabs.showAudioPlayingIcon = false is a clumsy workaround, but as soon as a tab is muted, the problem appears again. The mute icon cannot be disabled via configuration.

If it helps, https://bugzilla.mozilla.org/show_bug.cgi?id=486262 is where this icon is implemented.

roryokane commented 7 years ago

To be clear, the desired functionality would be to cut off only the title of the tab that has the audio icon. Other tabs with no audio icons should stay their full lengths.

The relevant code can be founded by searching bootstrap.js for .hasAttribute('muted'). Here’s a link to the first of the seven results, all of which might be relevant. Four of the lines containing that search string are this identical line, having been copied and pasted:

treecol.overlay.collapsed = !Array.some(g.tabs, (x) => !x.pinned && (x.hasAttribute('muted') || x.hasAttribute('soundplaying')));
OmTatSat commented 7 years ago

i see this bug too(

OmTatSat commented 7 years ago

"but as soon as a tab is muted, the problem appears again. The mute icon cannot be disabled via configuration."

treecol.overlay.collapsed = !Array.some(g.tabs, (x) => !x.pinned && (x.hasAttribute('muted-') || x.hasAttribute('soundplaying-')));