search

traxium / tabtree

Tab Tree extension for Firefox
https://addons.mozilla.org/en-US/firefox/addon/tab-tree/
GNU General Public License v3.0
144 stars 30 forks source link

New tab won't open by doubleclicking tab area / clicking "Open a new tab" button #193

Closed allixx closed 7 years ago

allixx commented 7 years ago

Tab Tree 1.4.8 / Firefox 51.0 x64 / Win7. Cannot open a new tab by doubleclicking or middle-clicking tab area, or pressing "Open a new tab" button - nothing happens. "Open a new tab..." tab area popup menu items work. Default new tab shortcut Ctrl + T works as well.

All of those actions worked previously in Firefox 50 x64 / Win7.

EDIT: I don't see any documented Firefox 51 changes even remotely relevant to this issue. Does anyone have a suggestion how to approach debugging of this? I tried builtin Firefox addon debuger, but it fails to attach to Tab tree.

RokuZero commented 7 years ago

I have same problem. Debian testing x64. firefox 51.

igordavid commented 7 years ago

Same issue here - Firefox 51 64-bit, MAC Version 10.11.6

Double-click on the empty area doesn't open a new tab. It was working before in previous version of Firefox.

The same issue is happening with "Tree Style Tab", also I tried add-on "Classic theme restorer" but didn't help.

Anyone found a solution?

Thanks in advance!

elrac commented 7 years ago

Also not working in Firefox 51.0.1 (32-bit) in Windows 10.

None of the methods of opening a new tab other than ctrl-t work. I tested double click, scroll click, and clicking the + button.

freeseacher commented 7 years ago

Same on linux mint ff 51

mrd000 commented 7 years ago

I have the same problem on the most recent version @traxium. The error in the console is: TypeError: aDOMWindow.BrowserOpenNewTabOrWindow is not a function bootstrap.js:2758:4

allixx commented 7 years ago

https://github.com/mozilla/amo-validator/issues/473

Replacing BrowserOpenNewTabOrWindow calls with BrowserOpenTab seem to solve this. But due to impossibility of using non signed addons in branded Firefox, author has to fix this himself, or someone has to fork Tab tree and register as a new component. :(

allixx commented 7 years ago

duplicate of https://github.com/traxium/tabtree/issues/170 apparently it is already fixed in master, just not released as a new version. :)

mrd000 commented 7 years ago

Should we keep this open until a new version is released then? Because it's still a problem and it's not gone away.

allixx commented 7 years ago

request to the author to release updated version should be in a different issue, I think.