treacherousfiend / RoR2-VoidFiendHudTweaks

A collection of tweaks to Void Fiend's corruption hud
Creative Commons Zero v1.0 Universal
0 stars 0 forks source link

Void potentials sometimes unusable for clients when host is playing as void fiend #1

Open LordVGames opened 1 month ago

LordVGames commented 1 month ago

AFAIK this was the only problem caused by the mod. We were playing simulacrum and I (the host) was playing as void fiend while 2 other clients weren't, and every so often a void potential couldn't be interacted with by the clients. Sometimes those potentials were still there on my end and I could choose the item for them while other times they weren't there.

This error was being spammed in one of the clients log:

[Error  : Unity Log] NullReferenceException
Stack trace:
UnityEngine.GameObject.GetComponent[T] () (at <85d1d3e7744a4a47b5f51883bf40bba2>:IL_0021)
VoidFiendHudTweaks.VoidFiendHudTweaks.UpdateCorruptionDeltaNotices () (at <a47a88b3ee9546f3953dacefb5366673>:IL_001B)
VoidFiendHudTweaks.VoidFiendHudTweaks.VoidSurvivorController_OnCorruptionModified (On.RoR2.VoidSurvivorController+orig_OnCorruptionModified orig, RoR2.VoidSurvivorController self, System.Single newCorruption) (at <a47a88b3ee9546f3953dacefb5366673>:IL_0191)
DMD<>?-536932096.Hook<RoR2.VoidSurvivorController::OnCorruptionModified>?-1842606336 (RoR2.VoidSurvivorController , System.Single ) (at <fe03b8ceebe34842b6bc144c914979c5>:IL_0014)
RoR2.VoidSurvivorController.OnDeserialize (UnityEngine.Networking.NetworkReader reader, System.Boolean initialState) (at <78ca0507428e4dbea7a28fe14402f720>:IL_002E)
UnityEngine.Networking.NetworkIdentity.OnUpdateVars (UnityEngine.Networking.NetworkReader reader, System.Boolean initialState, UnityEngine.Networking.NetworkMessage netMsg) (at <0979500d450f40e18351f1e5893a2968>:IL_0012)
UnityEngine.Networking.ClientScene.OnUpdateVarsMessage (UnityEngine.Networking.NetworkMessage netMsg) (at <0979500d450f40e18351f1e5893a2968>:IL_0059)
UnityEngine.Networking.NetworkConnection.HandleReader (UnityEngine.Networking.NetworkReader reader, System.Int32 receivedSize, System.Int32 channelId) (at <0979500d450f40e18351f1e5893a2968>:IL_012D)
UnityEngine.Networking.NetworkConnection.HandleBytes (System.Byte[] buffer, System.Int32 receivedSize, System.Int32 channelId) (at <0979500d450f40e18351f1e5893a2968>:IL_0007)
UnityEngine.Networking.NetworkConnection.TransportReceive (System.Byte[] bytes, System.Int32 numBytes, System.Int32 channelId) (at <0979500d450f40e18351f1e5893a2968>:IL_0000)
RoR2.Networking.SteamNetworkConnection.TransportReceive (System.Byte[] bytes, System.Int32 numBytes, System.Int32 channelId) (at <78ca0507428e4dbea7a28fe14402f720>:IL_0019)
RoR2.Networking.NetworkManagerSystemSteam.OnP2PData (Facepunch.Steamworks.BaseSteamworks receiver, CSteamID senderSteamId, System.Byte[] data, System.Int32 dataLength, System.Int32 channel) (at <78ca0507428e4dbea7a28fe14402f720>:IL_0044)
RoR2.Networking.NetworkManagerSystemSteam.OnSteamClientP2PData (System.UInt64 senderSteamId, System.Byte[] data, System.Int32 dataLength, System.Int32 channel) (at <78ca0507428e4dbea7a28fe14402f720>:IL_000C)
Facepunch.Steamworks.Networking.ReadP2PPacket (System.Int32 channel) (at <0ca17294c1634ce4acda47c711e5ecf1>:IL_0082)
Facepunch.Steamworks.Networking.Update () (at <0ca17294c1634ce4acda47c711e5ecf1>:IL_0054)
Facepunch.Steamworks.BaseSteamworks.Update () (at <0ca17294c1634ce4acda47c711e5ecf1>:IL_0006)
Facepunch.Steamworks.Client.Update () (at <0ca17294c1634ce4acda47c711e5ecf1>:IL_0025)
RoR2.SteamworksClientManager.Update () (at <78ca0507428e4dbea7a28fe14402f720>:IL_0006)
RoR2.RoR2Application.Update () (at <78ca0507428e4dbea7a28fe14402f720>:IL_005F)
treacherousfiend commented 1 month ago

Huh, I'll take a look when I get the chance, to be honest i'm really inexperienced with with RoR2 modding so I'm surprised the mod is doing anything network related.

treacherousfiend commented 1 month ago

oops, didn't mean to close this yet since I'm not actually sure if I did fix this in the latest version. I was able to reproduce and fix the error spam but not the void potential issue. I'm not sure if its related to my mod at all to be honest, since I don't think I touch anything close to that.

LordVGames commented 1 month ago

the void potential thing was probably a byproduct of the errors since they were networking related. whenever i play multiplayer simulacrum as viend again i'll post here if it was fixed or not

treacherousfiend commented 1 month ago

Got it, I'll keep the issue open for now