search

trema-tech / moodle-theme_trema

Theme trema, a Moodle LMS plugin.
https://moodle.org/plugins/theme_trema
GNU General Public License v3.0
39 stars 19 forks source link

Login form: password-reset-option missing if "remember user" is deactivated in admin settings #106

Closed dermuck closed 2 years ago

dermuck commented 2 years ago

The default login-window contains 3 informations directly below the login-button:

Disabling the option rememberusernames in admin settings causes theme trema to remove the corresponding checkbox AND the link to the password-reset-functionality from the login window, rendering the user helpless if he forgot his password.

issue_resetpassword
michael-milette commented 2 years ago

Hi @dermuck ,

I agree that having the option to enable/disable remembering the username is good.

I also think that it is good to have an option to control the visibility of the forgot password link is very useful too.

I agree that both options should NOT be controlled by the same Moodle setting. I have worked with many organizations who don't want the user browser to remember the username but they DO want the link to change the password.

What would be even better would be to create a Trema setting that would allow the administrator to customize the forgot username or password link.

Use case A: If this new text field is empty, the link would be removed from the login page for those organizations who don't want to show the link at all. Example: internal Moodle site where all students use the same username and password. Though this is not recommended, some situations do call for it.

This solution would also enable administrators the option of changing the URL completely. Example:

Use case B: Some organizations might prefer to have a link to a helpdesk form where a user could request help to login.

Use case C: Some organization, who use OAuth2 or other authentication method, might also have their own custom URL for resetting a password.

Best regards,

Michael Milette

dermuck commented 2 years ago

Hi @michael-milette , the moodle setting rememberusername is indeed a very useful option, and it prevents the system from setting another cookie. Also the use cases for setting a custom password reset URL are quite likely to occur in many moodle installations out there. But I do not agree with You that there should be a setting to control the password reset URL within theme Trema.

There may be moodle installations that offer more than one theme, and recovering your password should not be theme-dependent. For the uses cases You described above, there already exists a moodle-option to set a custom URL. Its named forgottenpasswordurl, You can find it in the auth plugins overview (/admin/settings.php?section=manageauths). Any new Trema-specific setting might collide with this existing setting. Therefore I personally would prefer fixing the display bug in Trema and not messing around with system-wide settings within a theme.

Best regards, Markus

michael-milette commented 2 years ago

Hi @dermuck ,

Good point. I forgot about forgottenpasswordurl. Go ahead and fix it at your convenience.

Best regards,

Michael

rarnott001 commented 2 years ago

Hi. Any chance of telling me where to find this setting. new trema installed in moodle 4.x and the forgotten username and password option has disappeared from login screen

michael-milette commented 2 years ago

So nice to have this fixed in the latest release here on GitHub. Thank you @rmady !

Best regards,

Michael