trema-tech / moodle-theme_trema

Theme trema, a Moodle LMS plugin.
https://moodle.org/plugins/theme_trema
GNU General Public License v3.0
40 stars 20 forks source link

Site Admin search form and Site Administration width is not applied (SOLUTION INCLUDED) #140

Closed git4ths closed 8 months ago

git4ths commented 1 year ago

Hi Team,

First of all, I really love the theme so congratulations! I am a bit of perfectionist and I want everything in order. I noticed that the Search form and Site administration are near to each other. You'll see the problem below

image

This is the correct one though, but it is on another page

image

michael-milette commented 1 year ago

Hi @git4ths ,

I am not sure I follow what you are trying to explain. Could you perhaps try again and include the steps to reproduce the issue?

Best regards,

Michael

git4ths commented 1 year ago

Sorry, for the vague report.

If you click Site Administration via the Navigation bar at the top. You will notice that the search form was close to the Heading "Site Administration" as you will see at the picture below:

image

But if you go to "Site Administration > Appearance > Themes (Trema)." You will see on the screenshot below, the correct spacing of the Heading and the search form. I tried switching it to the Boost preset, and was able to confirm that they should be far from each other like on the screenshot below.

image

If the Site Administration and search form are intentionally setup that way, that's fine. However, any raw scss code to set them apart would be really helpful, thanks!

michael-milette commented 1 year ago

Hi @git4ths ,

Thank you for the improved report. I see it now. It is shifted to the left (not centered) and missing space in between.

Michael

michael-milette commented 1 year ago

HI @git4ths ,

Here is a temporary workaround until the issue is fixed in Trema. Just add the following to the theme's SCSS:

// Temporary fix for Trema issue number 140.
#page-admin-search #page-header .mr-auto {
    margin-right: auto!important;
}
#page-admin-search #page-header {
    margin: 0 auto;
}

Best regards,

Michael Milette

michael-milette commented 8 months ago

Hi @rmady ,

Please test and integrate PR #180. Thanks!

Best regards,

Michael Milette

rmady commented 8 months ago

Thanks guys @git4ths and @michael-milette! I'm working on the new release and this PR will be fixed over there. For instance, it is in the main branch.

Kind regards, Rodrigo Mady