trema-tech / moodle-theme_trema

Theme trema, a Moodle LMS plugin.
https://moodle.org/plugins/theme_trema
GNU General Public License v3.0
39 stars 19 forks source link

Moodle 4.2.1+ Dashboard Exception - Cannot access protected property core\check\result::$status #168

Closed chrisacameron closed 1 year ago

chrisacameron commented 1 year ago

Using Trema v 4.1.0.0 (2023042100), and after upgrading to Moodle 4.2.1+ (20230616), we are seeing the following error:

Error - Exception - Cannot access protected property core\check\result::$status

Other users also reporting the issue in comments at: https://moodle.org/plugins/theme_trema

Workaround: Site Administration > Appearance > Navigation : set Enable Dashboard (enabledashboard) to No OR Site Administration > Appearance > Navigation : set Start page for users (defaulthomepage) to something besides Dashboard (but the Error will still be generated if user clicks on Dashboard link in top navigation)

markginter31 commented 1 year ago

I have this same bug.

BK787 commented 1 year ago

Likewise.

snack753 commented 1 year ago

Same for me ...

cpaschen commented 1 year ago

same here also

michael-milette commented 1 year ago

Using the version from Sept 8, I am no longer able to reproduce the issue. Thank you for fixing this @rmady !

alexjasoncrawl commented 1 year ago

Hey @michael-milette, Hey @rmady

The Dashboard Exception (Cannot access protected property core\check\result::$status) isnt fixed for Moodle 4.3+ (Build 20231110) Trema V4.1.0.0 2023042100

Please reopen the Issue.

Greeting AlexJasonCrawl

michael-milette commented 1 year ago

Hi @alexjasoncrawl ,

I am still unable to reproduce your issue. I would appreciate it if you could provide me with additional information.

As a Site Administrator, could you please navigate to Site Administration > Development and set Debug Messages to DEVELOPER: extra Moodle debug messages for developers. Also, make sure that the box to Display debug messages is checked. Save your changes and then do whatever you do to cause the error.

You should end up seeing more than just the Cannot access protected property core\check\result::$status message.

Please copy and paste the additional information back here. Don't forget to go back and set Debugging Messages to NONE.

Also, please describe any blocks or customized settings you might have as the problem may only be manifesting itself when the configuration is a certain way. My Moodle 4.3 test installation is pretty basic with very few custom settings. Any information that might help me re-create the problem would be most helpful.

Best regards,

Michael

snack753 commented 1 year ago

Hi Michael, I am afraid I will not be able to provide you with more details, since we decided to update to a compatible/older version of Moodle. Sorry, Kai

michael-milette commented 1 year ago

No problem Kai. Thanks for letting us know.

@markginter31 @chrisacameron @BK787 @cpaschen @alexjasoncrawl , can any of you help me track down this issue? Please try version 4.3.0.0 which was recently released (Nov 14). Specifically, if you can still reproduce the issue, please try it with the Trema Admin Dashboard enabled and disabled, and let me know if it makes a difference.

image

I just found a bug but the error does not match the one reported in this ticket.

Best regards,

Michael

snack753 commented 1 year ago

Hi Michael, I remembered that I still have access to V4.2.1 with Trema installed. The debug result shows this: Error Exception - Cannot access protected property core\check\result::$status Debug info: Error code: generalexceptionmessage Stack trace: line 194 of /theme/trema/locallib.php: Error thrown line 100 of /theme/trema/layout/mydashboard.php: call to theme_trema_get_environment_issues() line 1477 of /lib/outputrenderers.php: call to include() line 1403 of /lib/outputrenderers.php: call to core_renderer->render_page_layout() line 179 of /my/index.php: call to core_renderer->header()

Hope this helps

snack753 commented 1 year ago

PS: regarding the blocks on my dashboard. I have these blocks activated currently:

That's it. Nothing fancy

chrisacameron commented 1 year ago

No problem Kai. Thanks for letting us know.

@markginter31 @chrisacameron @BK787 @cpaschen @alexjasoncrawl , can any of you help me track down this issue? Please try version 4.3.0.0 which was recently released (Nov 14). Specifically, if you can still reproduce the issue, please try it with the Trema Admin Dashboard enabled and disabled, and let me know if it makes a difference.

image

I just found a bug but the error does not match the one reported in this ticket.

Best regards,

Michael

Still an issue with Moodle v4.3+ Build: 20231110 and Trema 4.1.0.0 Upgraded Trema to 4.3.0.0 and no longer an issue

michael-milette commented 1 year ago

Hi @chrisacameron ,

Thank you for getting back to me. Good to know that the issue has been resolved in v4.3.0.0. I will close this ticket.

If anyone else is able to reproduce the issue with v4.3.0.0 in Moodle 4.1, 4.2 or 4.3, please post details and I will reopen this ticket.

Best regards,

Michael Milette

michael-milette commented 1 year ago

@snack753 ,

Can you please confirm whether this is still an issue on Moodle 4.2.1 with Trema v4.3.0.0?

Michael

rmady commented 1 year ago

Looks like everything is all right now. Please, let me know if this issue is happening with someone else. Thank you very much guys