search

trema-tech / moodle-theme_trema

Theme trema, a Moodle LMS plugin.
https://moodle.org/plugins/theme_trema
GNU General Public License v3.0
40 stars 20 forks source link

Fix-168: PHP 8.2 compatibility issue with Admin Dashboard. #181

Closed michael-milette closed 7 months ago

michael-milette commented 7 months ago

Hi @rmady ,

When I go to the Dashboard, I get the following error in Moodle 4.3 with PHP 8.2. Note that this error appears under the header so it is only visible in the source code view:

Deprecated:  Automatic conversion of false to array is deprecated in /theme/trema/locallib.php on line 191

The reason this happens is that, if the following line fails to retrieve the information from the cache, the function returns 'false' and PHP 8.2 will not allow you to automatically convert this boolean into an array.

The attached PR addresses this issue. Hopefully, this will also address issue #168 .

Let me know if you have any questions or concerns.

Best regards,

Michael Milette

rmady commented 7 months ago

Thanks @michael-milette lol You are the best