Bug:banner images dont work properly when more than one

PTSdeveloper007 commented 2 months ago

Prerequisites

[X] I'm reporting the issue to the correct repository.
[X] I am running the latest version of this plugin (if not, please upgrade first).
[X] I checked the README.md and Wiki documentation but did not find my answer.
[X] I searched to make sure that this issue had not already been reported.
[X] I have, or I know someone who has, the ability and willingness to test the fix on a Moodle LMS-based site.
[X] I am submitting no more than one bug report per issue ticket (please do not submit multiple bugs in one issue ticket).
[X] I understand that support is provided by volunteer(s).

What happened?

How can i edit the banner slides on the frontpage please? and when you add more than one banner image, the image moves when scrolling down. any can help with this please ? thanks

What do you think should have happened?

the banner sliders to work correctly

Steps to reproduce

Login as '...' (specify user role)
Go to '...'
Click on '....'
Scroll down to '....'
See error or issue. You get it?

Screenshots

No response

Moodle version

Moodle 4.4.0

Installed Moodle UI Language packs.

[ ] English only
[ ] One or more other languages/regional dialects (specify below)
[ ] Other

If other language(s), please specify

No response

Workaround

No response

Additional information

No response

System information

Client Device type: (e.g. Desktop, iPhone or iPad, Android phone or tablet, Other - specify) Client Operating System: (e.g. Windows, Linux, Mac OS, Android, iOS, Other - specify) Client Web Browser: (e.g. Chrome, Edge, Firefox, Safari, Safe Exam Browser, Moodle Mobile App) Server Operating System: (e.g. Windows, Linux, Mac OS, Other - specify) Server Webserver: (e.g. Apache, Nginx, IIS, Other - specify) Server PHP: (e.g. 7.4, 8.0, 8.1, 8.2, 8.3, Other - specify)

Code of Conduct

[X] I have read and agree to the project's code of conduct.

rmady commented 2 months ago

Hello @PTSdeveloper007, Thank you for your contribution to Trema but I was unable to reproduce this bug. Please, can you send me a screenshot or a video of this issue?

Kind regards, Rodrigo Mady

PTSdeveloper007 commented 2 months ago

Hi, heres an image of issue. The banner slider doesnt stick to position but rather scrolls when you scroll down the page. This only happens when you add more than one image to the banner.

It works well when there is only one image in banner.

Thanks and hope to hear from you

Peter

PTSdeveloper007 commented 2 months ago

This is another issue please

with the list buttons (attached) the padding within the buttons is uneven when hover/focus.

Hope to hear from you

Peter

PTSdeveloper007 commented 2 months ago

more here

michael-milette commented 2 months ago

Hi @PTSdeveloper007

Thank you for the reports. We have been able to reproduce the issue with the carousel and are working on a solutions. Hopefully, we will have a fix this soon.

As for the > not being centered, this should be fixed along with several other small issues in the experimental "dev" branch and will be included in the upcoming release shortly. Please feel free to try it out and let us know if it works for you. Note that you may need to change a theme setting (any one should do) in order for the css to recompile and take effect. This step will not be required in the released version.

In the future, we would appreciate it very much if you would kindly only include one issue per ticket as this helps us keep track of what has been fixed and what still needs attention - as indicated in the Prerequisite section of the ticket that you checked.

Best regards,

Michael Milette

rmady commented 2 months ago

Hello @PTSdeveloper007, I just created a new version with these fixes. Please, check it out and let me know if everything is ok now.

Kind regards, Rodrigo Mady

PTSdeveloper007 commented 1 month ago

This is working now thank you!

trema-tech / moodle-theme_trema