trema-tech / moodle-theme_trema

Theme trema, a Moodle LMS plugin.
https://moodle.org/plugins/theme_trema
GNU General Public License v3.0
39 stars 19 forks source link

Bug: Text color of "Hidden from students" message #198

Closed bernardo1975 closed 1 month ago

bernardo1975 commented 1 month ago

Prerequisites

What happened?

When hiding an activity/section inside a Moodle course, a notification "Hidden from students" on dark background appears -- the problem, however, is that the text is also dark (see Pic 1 of the screenshots below). Highlighting the text with the mouse makes the text visible (Pic 2). Inspecting the html code, the issue is that "text-dark" is selected here (Pic 3). Changing this to "text-light" manually (Pic 4) has the expected and desired result, see Pic 5.

What do you think should have happened?

I expected the notification "Hidden from students" to look like Pic 5 (instead of like Pic 1).

Steps to reproduce

Hide activity/section as lecturer/administrator.

Screenshots

Pic 1: Screenshot_Hidden_1

Pic 2: Screenshot_Hidden_2

Pic 3: Screenshot_Hidden_3

Pic 4: Screenshot_Hidden_4

Pic 5: Screenshot_Hidden_5

Moodle version

Moodle 4.4.2 (Build: 20240812)

Installed Moodle UI Language packs.

If other language(s), please specify

No response

Workaround

No, unfortunately not.

Additional information

No response

System information

Client Device type: (e.g. Desktop, iPhone or iPad, Android phone or tablet, Other - specify) Client Operating System: (e.g. Windows, Linux, Mac OS, Android, iOS, Other - specify) Client Web Browser: (e.g. Chrome, Edge, Firefox, Safari, Safe Exam Browser, Moodle Mobile App) Server Operating System: (e.g. Windows, Linux, Mac OS, Other - specify) Server Webserver: (e.g. Apache, Nginx, IIS, Other - specify) Server PHP: (e.g. 7.4, 8.0, 8.1, 8.2, 8.3, Other - specify)

Code of Conduct

michael-milette commented 1 month ago

Hi @bernardo1975 ,

I am having trouble reproducing the issue. It may be related to a particular colour combination. Are you using the latest version of Trema?

It would be helpful if you could please share your Trema colour settings with me including:

If you can get these to me soon, I will try to include a fix for this in the upcoming update of Trema.

Best regards,

MIchael

bernardo1975 commented 1 month ago

Hi Michael @michael-milette ,

sure, no problem. The version of Trema is 4.4.0.5 (2024071600).

Trema colour settings:

Best & thank you. Bernd

bernardo1975 commented 1 month ago

I just updated to 4.4.0.6 (2024090500) with the same colour settings. It didn't resolve the problem.

michael-milette commented 1 month ago

Hi @bernardo1975 ,

Thank you for following up. I was able to successfully reproduce your issue. Please download and install release 4.4.0.7 which should solve the problem for you.

If you would be so kind, I would be thankful if you could let me know if this works for you too.

Best regards,

Michael Milette

bernardo1975 commented 1 month ago

Great, thanks Michael @michael-milette , it worked: Screenshot_20240906_154028