Fix-86: Frontpage now has hidden H1 but only read by screen readers.

trema-tech / moodle-theme_trema

Theme trema, a Moodle LMS plugin.

https://moodle.org/plugins/theme_trema

GNU General Public License v3.0

40 stars 20 forks source link

Fix-86: Frontpage now has hidden H1 but only read by screen readers. #98

Closed michael-milette closed 2 years ago

michael-milette commented 2 years ago

This addresses the issue reported in #86. Notes:

The new page title is in a hidden page title which is only read by screen readers.
The page title is present regardless of whether you are displaying a banner or carousel.
The mustache code for the banner/carousel has been refactored slightly. It is now simpler and parts of the carousel are no longer left behind when displaying a single banner.

Let me know if you have any questions or concerns.

Best regards,

Michael

michael-milette commented 2 years ago

Hi @rmady ,

The following line from this patch did not to make it into version 4.0 of Trema. This is an accessibility issue as it results in a Home page with no H1. Could you please add it in?

<h1 class="sr-only container pb-0 mb-0 mt-5">{{sitename}}</h1>

Best regards,

Michael