trembon / switch-library-manager

Complete solution to manage, organize and keep your local switch backup game library up to date . Cross platform, supports all game formats.
MIT License
76 stars 5 forks source link

incorrect metadata when organizing multi-content files #66

Closed Halofan240 closed 1 month ago

Halofan240 commented 2 months ago

Games that have the updates and dlc combine with them show up as update when organizing with the updates and dlc folder active.

Example below is breath of the wild xci that has the updates and dlc added to it. So, it shows up as multi-content. But when organized it ends up in the updates folder which you can see in the file path. Despite the fact it's not an update. Also when using {TYPE} it will show up with a UDP added to it.

image
benspray commented 2 months ago

also seeing this, seems if you organise again it will rename back to v0 and remove the UPD tag, seems to flip between marking as base and marking as update each time you organise

Halofan240 commented 2 months ago

Same with me on this too.

trembon commented 1 month ago

fix should be available in the latest beta build under the Actions tab here on GitHub

benspray commented 1 month ago

mostly working, still have a few files that get renamed as updates and move to subfolders ;) may be due to the fact that either they also have DLC or that they are "old updates" in the issues tab shows newer updates are in other nsp files so maybe the app doesnt know what to do with these

trembon commented 1 month ago

@benspray do you know what those multi-content contain? if its only dlcs and updates, the manager wont know what to do with the files

benspray commented 1 month ago

Hi, they include base,dlc and update the only difference I can see from working ones are that I have newer/duplicate updates in separate files (which are working ok) I'll try deleting the newer/duplicate update files and see if that helps 👍

benspray commented 1 month ago

I think that sorts it, if you have a "duplicate" ie a multipart xci with updates and dlc and then an nsp with maybe a newer update, it will rename the xci as an update and move it to the subfolder. if you remove all of the other nsp files and rescan it will then see it as base and rename properly (but you have to manually move it back out of the updates folder). As soon as you drop one of the other "duplicate" nsp files in it breaks the xci again by renaming and moving it as an update. Not sure what the fix would be here? Cheers

trembon commented 1 month ago

thanks for your finding, i will try to reproduce it on my end and see what i can find

i added logging for when it skips organizing a file due to multi-content, do you have any logs for this when trying to organize it in this scenario?

trembon commented 1 month ago

i tried with the following setup base game + old update in a .xci file new update in .nsp file 2 separate dlcs in .nsp files

i have no problem when trying to organizing these file and i have no scenario where the multi-content file is placed wrongly, do i understand your file setup wrong?

benspray commented 1 month ago

Hi, no that sounds exactly right, maybe just something odd about a few files, it only happens on 3 or 4 files, I may be best just to replace/redump the ones with issues 👍

trembon commented 1 month ago

fix is included in the 1.9.0 release