Only images are highlighted as changed when adding entire new chapter

joelostblom commented 2 months ago

In this PR I added an entire new chapter to the built book https://github.com/joelostblom/viz-oer/pull/29. However, in the deploy preview, only the images are highlighted in green as "changed", not the text. I was expecting the text to also be green, but maybe there is some max on how big of a change is marked up?

I'll leave that PR up until you have had time to have a look

trevorcampbell commented 2 months ago

Interesting. I think what's happening is:

the images are diffed separately (and independently) from .html pages, so the code is correctly finding new graphics and highlighting them
Our convention for new .html pages is to just colour links pointing to them green, but otherwise leave them alone as it's hard to reliably apply a style over an entire page (subelements will override that style)

But seeing your example, it is a little bit weird. I wonder if just inserting a large top element with green text "This whole page is new" or something like that is the right strategy...it will mess up the page a little bit potentially, but that's OK since it's just a diff anyway.

joelostblom commented 2 months ago

I see, the current convention of not marking up entire pages makes sense, and I think it would be helpful with a banner/message on the top of a file if the entire file is new, as you suggested.

trevorcampbell / website_diff

Only images are highlighted as changed when adding entire new chapter #23