search

trickerer / Trinity-Bots

NPCBots for TrinityCore and AzerothCore 3.3.5
https://github.com/trickerer/TrinityCore-3.3.5-with-NPCBots/
473 stars 157 forks source link

[AC] [Bug] [Spell/Core] Spell Penetration not being recognized by bots with some items #821

Closed Day36512 closed 3 months ago

Day36512 commented 5 months ago

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

Current behaviour

image

Bonked my warlock to see if spell penetration was being considered from an item upgrade. It did not get considered. Item in question uses spellids for stats, so i switched the item to raw stat values and spell pen was picked up then.

Expected behaviour

No response

Crashlog

No response

Steps to reproduce the problem

1} Test on a bot using an item that has spell pen baked in as a spellid rather than raw stat

TrinityCore or AzerothCore

Azerothcore

Core rev. hash/commit

AzerothCore rev. 3752ad5da884+ 2024-06-06 14:08:58 -0600 (npcbots_3.3.5 branch) (Win64, RelWithDebInfo, Static) (worldserver-daemon)

Operating system

Win10

trickerer commented 4 months ago

From testing results: spell penetration stat applies from both spells and item stats, spell auras just aren't taken into account when using /bonk - just a visual bug

trickerer commented 4 months ago

https://github.com/trickerer/AzerothCore-wotlk-with-NPCBots/commit/88bb14dc9a0b970ac139afc35e7737b52f66977c

trickerer commented 3 months ago

https://github.com/trickerer/Trinity-Bots/commit/bbc4e92810f7bb9db391a6746b1374b5473e8a11