search

trickerer / Trinity-Bots

NPCBots for TrinityCore and AzerothCore 3.3.5
https://github.com/trickerer/TrinityCore-3.3.5-with-NPCBots/
472 stars 157 forks source link

[AC] [Bug] [Spell] Flasks are stucks and do not replace each other #849

Closed Bogir closed 3 months ago

Bogir commented 4 months ago

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

Current behaviour

In case of giving some flasks, eat or dring (with buff) to bots, the spell-effects are combined with each other and do not replace if spell-effects are the same.

Если ботам давать всякие зелья, еду или написки с эффектами бафа - эффекты заклинаний стакаютсяя, даже если они однотипные, хотя должны замещать свои аналоги с более слабым действием. Screenshot_2

Expected behaviour

No response

Crashlog

No response

Steps to reproduce the problem

No response

TrinityCore or AzerothCore

AzerothCore

Core rev. hash/commit

7d15ea557eb1b76fae1bf682bc171dae5e2ee49b

Operating system

Windows

Day36512 commented 3 months ago

same if you're a paladin casting blessings on a bot. seems they ignore spell_group_stack_rules

trickerer commented 3 months ago

There is a hack which disables stacking rules for npcbot passive AoE auras since the calculation consumes so much CPU but looks like its application is unexpectingly broad. Also with the implementation of hidden spawns it's no longer needed.

trickerer commented 3 months ago

https://github.com/trickerer/Trinity-Bots/commit/986e776ad41e85ded1bdba03c6124dd3021e450e