trickerer / Trinity-Bots

NPCBots for TrinityCore and AzerothCore 3.3.5
https://github.com/trickerer/TrinityCore-3.3.5-with-NPCBots/
473 stars 157 forks source link

[AC] [Bug] [Equipment] NPCBots can equip multiple Unique items at the same time. #915

Closed Badgermilk0 closed 2 weeks ago

Badgermilk0 commented 2 weeks ago

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

Current behaviour

Currently NPCBots can equip more then 1 unique items, ex. 2 Bloodclot Band Rings at the same time.

image

Expected behaviour

Not being able to use more then one of the same Unique Item at the same time.

Crashlog

No response

Steps to reproduce the problem

No response

TrinityCore or AzerothCore

AzerothCore

Core rev. hash/commit

AzerothCore rev. dca2df72439d 2024-10-26 05:40:12 +0700 (npcbots_3.3.5 branch)

Operating system

Win 11

Bogir commented 2 weeks ago

in addition, the bot ignores almost all checks for wearing or using items, stones for sockets or improvements that are required by a regular character. I think this is a big plus. The main thing for you is to control these moments and use them to compensate for some unfinished spells or abilities of bots.

trickerer commented 2 weeks ago

That's intended. Bots don't need to follow every player rule. That' not a big deal and to prove it this is the only report pointing that out as a problem in 10 years. Now, the reason that's intended is because if bot can't equip an item it just won't show in the repective menu. And if player forgets what bot has equipped it may take them quite some time to figure out that the problem is item's unique / unique-equipped status. In case of unique gems it's even worse. I don't want to frustrate players with such discoveries so bot will just grab the item. Stuff 'em full of Dragon's Eyes. Bots will also ignore skill requirements (ring enchantments, etc.) and race restrictions. Fury Warrior bots are also able to Titan Grip some weapon types players cannot.