search

trinodb / grafana-trino

The Trino datasource allows to query and visualize Trino data from within Grafana.
Apache License 2.0
35 stars 10 forks source link

Custom Grafana Dashboard Variable Support (2) #249

Closed vytautas-karpavicius closed 9 months ago

vytautas-karpavicius commented 9 months ago

This is based on original PR#245 with fixed build.

When select Trino plugin in Grafana while adding query variable. It was not showing a text area where user can put query.

Fixes https://github.com/trinodb/grafana-trino/issues/197

cla-bot[bot] commented 9 months ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

nineinchnick commented 9 months ago

@cla-bot check

cla-bot[bot] commented 9 months ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] commented 9 months ago

The cla-bot has been summoned, and re-checked this pull request!

nineinchnick commented 9 months ago

@vytautas-karpavicius the commits in this PR were made by a different GH user, which is not the one you used to sign the CLa with. Can you rebase the branch using the right user?

cla-bot[bot] commented 9 months ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

vytautas-karpavicius commented 9 months ago

@vytautas-karpavicius the commits in this PR were made by a different GH user, which is not the one you used to sign the CLa with. Can you rebase the branch using the right user?

@nineinchnick I have rebased and the CLA check passes now.

vytautas-karpavicius commented 9 months ago

@nineinchnick Thanks for merging it! Would it be possible to do a release for this?

nineinchnick commented 9 months ago

@vytautas-karpavicius done! And I submitted the plugin update to Grafana. Thanks for your contributions!