tripal / tripal_analysis_expression

Extension module for the Tripal toolset to show differential expression data. This module was made for Drupal 7, Tripal 3, and Chado 1.3.
GNU General Public License v2.0
4 stars 11 forks source link

Biosample loader crashes browser #384

Closed spficklin closed 2 years ago

spficklin commented 3 years ago

Using the code in PR #382 I am able to see the CV term configuration section as expected (previously I wasn't). However, the following lines of code create problems:

https://github.com/tripal/tripal_analysis_expression/blob/35a51746462a81b9a046aa81d8992d285961b1ee/tripal_biomaterial/includes/TripalImporter/tripal_biomaterial_loader_v3.inc#L1068-L1077

Essentially, they iterate through every line of my CSV file with 475 biosamples in it and add every single entry as a potential categorical value that needs a CV term assigned. This is overwhelming for the browser because it includes all the SRR numbers, etc.

I think that code needs to be smarter about determining which columns are categorical and which are not. For now in PR #382 I commented that code out so the page would load. But it needs a fix especially for users loading CSV files from the NCBI SRA run selector.

spficklin commented 2 years ago

Fixed as per PR #392