tripfab / TripFab

The TripFab application
tripfab.com
GNU General Public License v2.0
1 stars 2 forks source link

Conflicting Activity Content (URGENT) #543

Closed ErinRaub closed 12 years ago

ErinRaub commented 12 years ago

This screenshot should help illustrate: http://farm8.staticflickr.com/7101/7212254862_a973560fa5_h.jpg

It appears that activities with the same/similar name (not sure if it's site-wide or just per destination) are overlapping each other. Specific example, Desafío's and Green Way's Caño Negro Wildlife Refuge. Please note that in the backend admin, Desafío's tour is called Caño Negro Wildlife Refuge, and Green Way's is Caño Negro Wildlife Refuge. (The period is part of the name.) They overlap nonetheless.

If you navigate to La Fortuna > Activities (https://developer.tripfab.com/en-US/costa_rica/la_fortuna#/activities), look for Caño Negro Wildlife Refuge. (For me, it's on the top right.) You can see that this tour belongs to Desafío, and that it's description begins, "Giligan’s “three-hour tour” turned into years in paradise – and you'll strike a good balance..."

However, if you click on that tour, you get https://developer.tripfab.com/costa_rica/la_fortuna/caño_negro_wildlife_refuge, which immediately redirects to https://developer.tripfab.com/en-US/costa_rica/la_fortuna/caño_negro_wildlife_refuge -- Green Way's Caño Negro tour.

Furthermore, if you navigate back to the La Fortuna Activities list, you won't find the Green Way tour.

A site I helped launch last year experienced a similar problem with duplicate names, and the only solution was to have completely unique names for that field -- and have a built-in name checker to assure the unique names. I'm not sure if that's the problem here, but if it is, it should be verified whether names must be unique site-wide, or just within the same destination. For example, if a San José tour operator also offered a Caño Negro daytrip, could the San José > Activities page have a tour called Caño Negro Wildlife Refuge without having any conflict with the La Fortuna tour?

ErinRaub commented 12 years ago

Sorry if that was overly complicated or detailed.

caraya0789 commented 12 years ago

@ErinRaub thanks for report. Not overly complicated or detailed at all. That's how a good bug report looks like ;-)

We are 100% aware of this bug, It just happen for listings with the same name on the sane destination. We will use the solution you propose, but I'm trying to keep urls as clean as possible.

I love creative titles and this is for everyone. Two or more listings with the same name and the same city doesn't make any difference to the user, who will think it is the same listing (even if we fix the url problem) just offered by another tour operator, So I suggest guys, be creative with titles, make them unique, make feel the user that two equal listings can be completely different depending on operator who offers it.

In the mean time, I would try to figure out a way to prevent listings with the same name/url

@sobrado Any thoughts on this regard?

sobrado commented 12 years ago

@GennaMarie has been wroking on it this week... Titles for trips and activities will be changing , slowly but surely.

caraya0789 commented 12 years ago

cool