Decide security of user passwords storage

[kristjanjansen]

In order to allow legacy Drupal users to log in with their usernames and passwords we introduced md5() as a new hasher service. See also https://github.com/tripikad/trip2/issues/3

This is not considered secure and Laravel's original bcrypt() is considered way more secure hasher.

We need to choose:

Option A: md5() AND bcrypt() -- decided

• We should be able keep our passwords secure AND also keep the old passwords

https://www.reddit.com/r/PHP/comments/3lwxlw/hash_and_verify_passwords_in_php_the_right_way/cva6y6p

Option B: Keep insecure md5()

• More fluent user experience for existing users in site upgrade
• We are left with a a database of more hackable user credentials
• Complicated process of upgrading passwords to be more secure if we need to
• Our custom md5 hasher is implemented system-wide so we are are weakeing whatever hashes we need in the future

  Option C: Secure bcrypt()

• Legacy Drupal users need to reset their passwords
• We need to send an e-mails to every single user about site upgrade and need for resetting passwords
• Many e-mails are likely outdated / unreachable for users so they can not apply for new passwords
• Many frustrated users opt for a new account / FB login and lose connection with their existing accounts
• Huge impact on customer support

[kristjanjansen]

@mikkpokk idea:

Password generation for new users:

sha1(salt + md5(password))

Password generation for old users:

sha1(salt + password)

See also http://laravel.io/forum/03-18-2014-password-salt-just-wondering

[kristjanjansen]

Another idea:

Üheks tüüpilisemaks lahenduseks on teha uus hash järgmisel sisselogimisel. tühistad kasutaja sessiooni ära ja kui proovib sisse logida, siis kõigepealt kontrollid kas parool vastab vanale räsile. seejärel koostad sellestsamast tol hetkel veel teada olevast õigest paroolist uue räsi ja kirjutad baasis vana üle

[kristjanjansen]

https://www.reddit.com/r/PHP/comments/3lwxlw/hash_and_verify_passwords_in_php_the_right_way/cva6y6p

Basically Mikk's idea without salt (its already in default bcrypt() )

[kristjanjansen]

Closed in favour of #687