trustedlogin / trustedlogin-vendor

Plugin to interact with TrustedLogin's encrypted storage infrastructure to redirect support staff into an authenticated session on client installations.
GNU General Public License v3.0
0 stars 1 forks source link

Add react based settings page #68

Open Shelob9 opened 3 years ago

Shelob9 commented 3 years ago

63

Shelob9 commented 3 years ago

This is a work in progess PR. It adds a new settings page that supports multiple teams. My next step is to make this a tabbed layout that has tabs for each team's graphs. That is blocked by https://github.com/trustedlogin/trustedlogin-ecommerce/pull/482

Also I need to copy CSS of old settings page, then remove old settings page.

zackkatz commented 3 years ago

Let me know when it's ready for a detailed review.

Shelob9 commented 3 years ago

@zackkatz Yes and no. It's not done, needs graphs and layout work. But was hoping you could take a look before I went further. Wanted to make sure this direction made sense to you.

zackkatz commented 3 years ago

@Shelob9 The concept of having multiple teams, yes. It is a bit early for me to be able to say whether this approach feels right or not.

For example, I would want to have a setting page show up immediately if there haven’t been any teams configured already.

Shelob9 commented 3 years ago

@zackkatz Yesterday we said I would:

That third part I am unsure of. API_Handler class, is inited using the old settings in three places:

https://github.com/trustedlogin/trustedlogin-vendor/blob/424431677cb12ccf2ec540ad3c9f550cf311b2fa/includes/class-trustedlogin-endpoint.php#L563-L569

https://github.com/trustedlogin/trustedlogin-vendor/blob/424431677cb12ccf2ec540ad3c9f550cf311b2fa/includes/class-trustedlogin-endpoint.php#L655-L661

https://github.com/trustedlogin/trustedlogin-vendor/blob/424431677cb12ccf2ec540ad3c9f550cf311b2fa/helpdesks/class-tl-helpscout.php#L267-L273

What I am not sure of is how we would know what the account ID is for each request? If we knew that, then we could get that accounts settings via ID with new settings API.

Shelob9 commented 3 years ago

helpdesks/class-tl-helpscout.php