tscircuit / cli

Command line interface for developing circuits with tscircuit
1 stars 8 forks source link

fix: add dynamic import #124

Closed imrishabh18 closed 3 weeks ago

imrishabh18 commented 3 weeks ago

@seveibar Need your input in this. The Format is failing and I have tried few things, and it's most probably because of lockfile not updated, should we shift the npm install biome -> bun like in the workflow below?

name: Format PR

on:
  pull_request:
    types: [opened, synchronize, reopened, ready_for_review]

jobs:
  format:
    name: Format code
    runs-on: ubuntu-latest
    if: github.event.pull_request.draft == false

    steps:
    - name: Checkout code
      uses: actions/checkout@v3
      with:
        token: ${{ secrets.TSCIRCUIT_BOT_GITHUB_TOKEN }}

    - name: Setup Bun
      uses: oven-sh/setup-bun@v1
      with:
        bun-version: latest

    - name: Install dependencies
      run: bun install --frozen-lockfile

    - name: Diagnose @tanstack/virtual-core
      run: |
        bun pm ls @tanstack/virtual-core || true
        bun pm why @tanstack/virtual-core || true

    - name: Get @biomejs/biome version
      id: get-biome-version
      run: echo "BIOME_VERSION=$(bun x jq -r '.devDependencies["@biomejs/biome"]' package.json)" >> $GITHUB_OUTPUT

    - name: Install @biomejs/biome
      run: bun add -d @biomejs/biome@${{ steps.get-biome-version.outputs.BIOME_VERSION }}

    - name: Run formatter
      run: bun x @biomejs/biome format . --write

    - name: Commit changes
      uses: stefanzweifel/git-auto-commit-action@v4
      with:
        commit_message: "formatbot: Automatically format code"
        branch: ${{ github.head_ref }}
        commit_user_name: tscircuitbot
        commit_user_email: tscircuitbot@users.noreply.github.com
        commit_author: tscircuitbot <tscircuitbot@users.noreply.github.com>
seveibar commented 3 weeks ago

Taking a look

seveibar commented 3 weeks ago

Yea we can move it to bun, in the workflow i noticed you have "bun x" which i think should be "bunx"