search

tsquillario / Jamstash

HTML5 Music Streamer for Subsonic
http://jamstash.com
270 stars 88 forks source link

Select all queue items #222

Closed miicha closed 8 years ago

miicha commented 8 years ago

fixes #220 but working toggle functionality would be nice

Hyzual commented 8 years ago

Hi, sorry for taking so long to answer.

I've taken a look at the code you submitted and I can't merge it as is. I would prefer that you make a pull request for the develop branch rather than master. develop is pushed to http://beta.jamstash.com/ which lets people beta test features and see if anything is wrong. develop and master have quite a lot of differences right now. In theory, they should be the same since the current develop version is already a few months old and any major problems have been corrected but life has been pretty busy and either tsquillario or me didn't merge them yet.

Anyway, when I tried to rebase your work onto develop it didn't work, but I've been able to implement a working select all/toggle anyway. Give me a day or two and I'll push it to develop as v4.6.3

Hyzual commented 8 years ago

This was implemented in v4.6.3.