Mouse and media key fixes

pR0Ps commented 6 years ago

Update packages:

Didn't update everything to the absolute latest since there are compatibility issues
Reordered jquery above angular to fix some issues

Fix double click event propagation on the add/play/remove/star buttons:

When clicking these buttons quickly, the double click event would propagate and start playing the song
Fixed by extending the stopEvent directive to accept a comma-delimited list of events to stop. This allowed for using stop-event="click,dblclick" in the html to not propagate both click and double click events.
Removed some duplicate directives that seemed to have snuck in during a merge.

Rework of media keys and key processing:

Using space to play/pause was broken due to an issue with data binding. Running $scope.$apply() after updating the player.pauseSong property using player.togglePause() seems to have fixed this.
All of the key event processing has been moved into the JS. This means that all the key event logic is all in one spot (easier to understand IMO). Additionally, this removes the need to redefine functions for each shortcut.
Removed the now-unused angular-ui-utils/keypress.js package.
Fixed key events being active when editing dropdown/checkbox controls in the settings menu
Removed the custom [Home] shortcut since this is done natively by the browser already.
Removed the 1-6 shortcuts for the tabs. Logic being that it seems pretty rare that you would want to rapidly switch between them (you would have to use the mouse to do anything on all tabs except the subsonic one anyway), and they were already broken without anyone complaining.

pR0Ps commented 5 years ago

@tsquillario @Hyzual Any update on this?

Hyzual commented 5 years ago

See discussion on #245

tsquillario / Jamstash