search

tue-robotics / tue_robocup

RoboCup challenge implementations
https://github.com/orgs/tue-robotics/projects/2
42 stars 12 forks source link

Inconsistent API of detect_faces #1264

Closed jlunenburg closed 1 year ago

jlunenburg commented 1 year ago

In perception.py, detect_faces either returns a list[image_recognition_msgs/Recognition] or a tuple[list[image_recognition_msgs/Recognition], stamp, depending on the input. This is error prone.

Whenever updating this, all uses in this repo as well as other packages/repos (action_server) need to be checked.

MatthijsBurgh commented 1 year ago

I think this one is very easy. Just always return the stamp. Than the user can determine to use it or not

PetervDooren commented 1 year ago

1265