search

tue-robotics / tue_robocup

RoboCup challenge implementations
https://github.com/orgs/tue-robotics/projects/2
42 stars 12 forks source link

(Place) Removed useless motion of arm and improved docs #1317

Closed P-ict0 closed 1 year ago

P-ict0 commented 1 year ago

Current implementation: Robot goes to the prepare_place pose BEFORE navigating to the place pose. PR: Robot now doesn't move to the prepare_place pose anymore at any moment.

Also changed some asserts to use more correct type checking

PetervDooren commented 1 year ago

It is already broken for robots other than Hero. We don't have the infrastructure to properly support 'any' robot. What happened here is that the functionality of PUT was implicitly changed due to switching to collision avoidance. As long as the other robots keep a similar functionality it will remain consistent.

PetervDooren commented 1 year ago

@MatthijsBurgh, the check_type is a correct improvement but it has nothing to do with the changes in this PR. The changes here are fine and can be merged without worrying about changing check type as well. If we want to change this check type I suggest doing it in a small PR rather than delaying this one any further.

MatthijsBurgh commented 1 year ago

@PetervDooren changes were already made to these lines. So therefore the changes need to be correct and complete.

I applied the changes.

PetervDooren commented 1 year ago

@PetervDooren changes were already made to these lines. So therefore the changes need to be correct and complete.

I applied the changes.

No they were not. A commented line was removed. That does not make Rodrigo responsible for fixing all the lines near that. That is not how this works.