search

tuenti / secrets-manager

A daemon to sync Vault secrets to Kubernetes secrets
Apache License 2.0
171 stars 26 forks source link

token lookup refactor, improve test coverage and adds more metrics #14

Closed fcgravalos closed 5 years ago

fcgravalos commented 5 years ago

Distinguish between different kind of token read errors Improve test coverage Adds more metrics

codecov-io commented 5 years ago

Codecov Report

Merging #14 into master will increase coverage by 4.66%. The diff coverage is 73.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   76.07%   80.73%   +4.66%     
==========================================
  Files          11       11              
  Lines         397      436      +39     
==========================================
+ Hits          302      352      +50     
+ Misses         78       66      -12     
- Partials       17       18       +1
Impacted Files Coverage Δ
backend/backend.go 66.66% <ø> (ø) :arrow_up:
secrets-manager/metrics.go 100% <ø> (ø) :arrow_up:
backend/vault_metrics.go 94.73% <100%> (+2.42%) :arrow_up:
errors/errors.go 100% <100%> (+30%) :arrow_up:
backend/vault.go 61.78% <59.57%> (+4.38%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d636131...c551ac4. Read the comment docs.