Closed fcgravalos closed 5 years ago
Merging #21 into release-0.2.0-rc.2 will increase coverage by
0.98%
. The diff coverage is75%
.
@@ Coverage Diff @@
## release-0.2.0-rc.2 #21 +/- ##
=====================================================
+ Coverage 82.61% 83.6% +0.98%
=====================================================
Files 11 11
Lines 443 427 -16
=====================================================
- Hits 366 357 -9
+ Misses 60 55 -5
+ Partials 17 15 -2
Impacted Files | Coverage Δ | |
---|---|---|
backend/vault_metrics.go | 100% <100%> (+5.26%) |
:arrow_up: |
backend/vault.go | 66.66% <50%> (+1.86%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5877f12...57d891a. Read the comment docs.
Rebased, though I don't think it's needed, we could have just merged later on into the release branch.
Added
secrets_manager_vault_max_token_ttl
metric, so a user could alert based on this andsecrets_manager_token_ttl
Fixed
secrets_manager_vault_token_expired
metric as it was quite confusing since it's not really possible forsecrets-manager
to actually not it's expired, just "close to expire"._total
suffix instead of_count
.secrets_manager_vault_token_lookup_errors_count
andsecrets_manager_vault_token_renew_errors_count
into one single metricsecrets_manager_vault_token_renewal_errors_total
with one more dimension calledvault_operation
which will be one oflookup-self, renew-self, is-renewable
.