tuenti / secrets-manager

A daemon to sync Vault secrets to Kubernetes secrets
Apache License 2.0
171 stars 26 forks source link

simplifies and makes clearer all vault prometheus metrics #21

Closed fcgravalos closed 5 years ago

fcgravalos commented 5 years ago

Added

Fixed

codecov-io commented 5 years ago

Codecov Report

Merging #21 into release-0.2.0-rc.2 will increase coverage by 0.98%. The diff coverage is 75%.

Impacted file tree graph

@@                  Coverage Diff                  @@
##           release-0.2.0-rc.2     #21      +/-   ##
=====================================================
+ Coverage               82.61%   83.6%   +0.98%     
=====================================================
  Files                      11      11              
  Lines                     443     427      -16     
=====================================================
- Hits                      366     357       -9     
+ Misses                     60      55       -5     
+ Partials                   17      15       -2
Impacted Files Coverage Δ
backend/vault_metrics.go 100% <100%> (+5.26%) :arrow_up:
backend/vault.go 66.66% <50%> (+1.86%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5877f12...57d891a. Read the comment docs.

fcgravalos commented 5 years ago

Rebased, though I don't think it's needed, we could have just merged later on into the release branch.