search

tuenti / secrets-manager

A daemon to sync Vault secrets to Kubernetes secrets
Apache License 2.0
171 stars 26 forks source link

Rename "*_count" metrics to "*_total". #22

Closed fllaca closed 5 years ago

fllaca commented 5 years ago

As following Prometheus recommended practices

codecov-io commented 5 years ago

Codecov Report

Merging #22 into release-0.2.0-rc.2 will not change coverage. The diff coverage is 88.88%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-0.2.0-rc.2     #22   +/-   ##
==================================================
  Coverage                83.6%   83.6%           
==================================================
  Files                      11      11           
  Lines                     427     427           
==================================================
  Hits                      357     357           
  Misses                     55      55           
  Partials                   15      15
Impacted Files Coverage Δ
kubernetes/metrics.go 100% <100%> (ø) :arrow_up:
secrets-manager/metrics.go 100% <100%> (ø) :arrow_up:
secrets-manager/secrets_manager.go 80.18% <100%> (ø) :arrow_up:
kubernetes/kubernetes.go 90.24% <66.66%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6397328...57ff94f. Read the comment docs.