search

tuenti / secrets-manager

A daemon to sync Vault secrets to Kubernetes secrets
Apache License 2.0
171 stars 26 forks source link

Add last sync status metric #23

Closed fllaca closed 5 years ago

codecov-io commented 5 years ago

Codecov Report

Merging #23 into release-0.2.0-rc.2 will increase coverage by 0.18%. The diff coverage is 100%.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           release-0.2.0-rc.2      #23      +/-   ##
======================================================
+ Coverage                83.6%   83.79%   +0.18%     
======================================================
  Files                      11       11              
  Lines                     427      432       +5     
======================================================
+ Hits                      357      362       +5     
  Misses                     55       55              
  Partials                   15       15
Impacted Files Coverage Δ
secrets-manager/secrets_manager.go 80.86% <100%> (+0.68%) :arrow_up:
secrets-manager/metrics.go 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8731954...815f28a. Read the comment docs.

dannyk81 commented 5 years ago
  • shouldn't be 0 -> ok, 1 -> not ok?

Actually, with Boolean metrics values are 1 for ok (true), 0 for not ok (false).

This is useful, since 0 computes to false and 1 to true and it works well with the bool modifier.

a good example is the builtin up metric, value (1) means UP, value (0) means DOWN.

  • constant instead of the values?