search

tuenti / secrets-manager

A daemon to sync Vault secrets to Kubernetes secrets
Apache License 2.0
171 stars 26 forks source link

Adding CA certificates to docker image #28

Closed rvojcik closed 5 years ago

rvojcik commented 5 years ago

Hi guys, I'm experimentig with secrets-manger. I found that output docker image doesn't have ca-certificates installed. If they are missing you get error when connecting to Vault something like x509 unknown issuer... I'm using certificates from Let's Encrypt.

codecov-io commented 5 years ago

Codecov Report

Merging #28 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #28   +/-   ##
=======================================
  Coverage   83.79%   83.79%           
=======================================
  Files          11       11           
  Lines         432      432           
=======================================
  Hits          362      362           
  Misses         55       55           
  Partials       15       15

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4636321...52967d6. Read the comment docs.

fcgravalos commented 5 years ago

@rvojcik Thanks a lot for using secrets-manager! We'll review your PR and let you know!

cc @dannyk81