Closed fcgravalos closed 5 years ago
CircleCI build failing beacuse (I think) mock switched to go modules, using golang.org/x/tools/packages
https://github.com/golang/mock/commit/79d8603a659da203b11a30b9faeb999604924d86
I fixed the above issue, but now hitting this weirdo:
mockgen -package mocks \
-destination mocks/kubernetes.go \
-source kubernetes/kubernetes.go \
-mock_names Client=MockKubernetesClient
2019/05/19 20:56:03 Loading input failed: unsupported version of go: exit status 2: flag provided but not defined: -compiled
usage: list [-e] [-f format] [-json] [build flags] [packages]
Run 'go help list' for details.
Makefile:54: recipe for target 'mocks' failed
make: *** [mocks] Error 1
Exited with code 2
Locally works, though :)
Merging #29 into master will increase coverage by
0.7%
. The diff coverage is91.17%
.
@@ Coverage Diff @@
## master #29 +/- ##
=========================================
+ Coverage 83.79% 84.49% +0.7%
=========================================
Files 11 11
Lines 432 458 +26
=========================================
+ Hits 362 387 +25
- Misses 55 56 +1
Partials 15 15
Impacted Files | Coverage Δ | |
---|---|---|
backend/backend.go | 100% <ø> (ø) |
:arrow_up: |
backend/vault_metrics.go | 100% <100%> (ø) |
:arrow_up: |
backend/vault.go | 68.84% <88.46%> (+2.17%) |
:arrow_up: |
backend/vault_engine.go | 87.5% <0%> (+12.5%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f2aa3b6...830c16b. Read the comment docs.
Had to update circleci golang version, that fixed it :)
Fixes #27
secrets-manager
will continue to renew its token, but in case there's a failure to fetch such token it will try login again and get a new one.cc @rvojcik